Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed redistribution between GOCART dust/sea salt and MOZAIC bins #2112

Merged

Conversation

saneku
Copy link
Contributor

@saneku saneku commented Sep 24, 2024

Bug fix in redistribution between GOCART dust/sea salt and MOZAIC bins in optical properties.

TYPE: bug fix

KEYWORDS: GOCART, optical properties, dust, sea salt, AOD

SOURCE: KAUST

DESCRIPTION OF CHANGES:
Problem:
It was found that WRF-Chem with GOCART aerosol scheme disregards the radiative effect of the largest dust and sea salt particles (5th and 4th bins).

Solution:
Mass redistribution between GOCART dust/sea salt and MOZAIC bins now accounts for the 5th dust and 4th sea salt bins. The number of MOZAIC bins was changed from 8 to 9 and MOZAIC max size range was increased from 10 to 20 um.

Table: Radii ranges (um) of dust and sea salt bins used in the GOCART aerosol module.
Screenshot 2024-09-25 at 10 20 26

Table: Size (um) ranges for MOSAIC grid used in calculation of optical properties. Last row - added 9th bin.
MOS1: 0.039-0.078,
MOS2: 0.078-0.156,
MOS3: 0.156-0.312,
MOS4: 0.312-0.625,
MOS5: 0.625-1.25,
MOS6: 1.25-2.5,
MOS7: 2.5-5.0,
MOS8: 5.0-10.0,
MOS9: 10.0-20.0

Table: Mass redistribution between GOCART dust/sea salt and MOZAIC bins. Numbers in bold - after modification.
Screenshot 2024-09-25 at 10 19 46

This PR is an addition to #667 and #677 PR.

LIST OF MODIFIED FILES:
M chem/module_optical_averaging.F
M chem/optical_driver.F

TESTS CONDUCTED:
7-day WRF-Chem run over the Middle East with the GOCART aerosol scheme was conducted without the changes (BEFORE) and with changes (AFTER). The figure below compares time-averaged AOD fields for both runs. As expected, AOD increased by 3% on average. Over dust source regions the AOD increase is more pronounced - 5% on average.
aod_aver

RELEASE NOTE: Bug fix in the calculation of optical properties. Mass redistribution between GOCART dust/sea salt and MOZAIC bins was corrected. It slightly increased (by 3-5%) the aerosol optical depth (AOD).

@saneku saneku requested a review from a team as a code owner September 24, 2024 19:22
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar weiwangncar changed the base branch from master to develop September 24, 2024 23:31
do m =1, 4
WRITE(*,*)m,seasfrc_goc9bin(m,:)
end do
!-----
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless this is controlled by a switch, these write statements should be removed or commented out for general use of the code.

commented diagnostic output
@weiwangncar
Copy link
Collaborator

@jordanschnell Just wondering if you could help review this PR - if it is not too involved.... Thanks!

jordanschnell
jordanschnell previously approved these changes Oct 10, 2024
Copy link
Contributor

@jordanschnell jordanschnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Approved.

add comment to reinitiate reg test
Copy link
Contributor

@jordanschnell jordanschnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@weiwangncar
Copy link
Collaborator

@jordanschnell Greatly appreciated!

@weiwangncar weiwangncar merged commit bb791e7 into wrf-model:develop Oct 10, 2024
1 check passed
@saneku
Copy link
Contributor Author

saneku commented Oct 16, 2024

@islas Could you please add this bug fix description to the v4.6.1 release in the chemistry section?

@islas
Copy link
Collaborator

islas commented Oct 16, 2024

@saneku It looks like this has gone into the develop branch. This would be included in the v4.7.0 release

Sorry for the confusion, especially in the midst of the v4.6.1 bug fix release being made before this PR is published in a release.

@weiwangncar
Copy link
Collaborator

@saneku Sorry that I didn't check the branch your PR was based before merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants