Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: update code in NativeAppBar #121

Closed
PritamBag opened this issue Sep 4, 2024 · 1 comment
Closed

enhancement: update code in NativeAppBar #121

PritamBag opened this issue Sep 4, 2024 · 1 comment
Assignees
@PritamBag
Labels
enhancement New feature or request

Comments

@PritamBag
Copy link
Member

Describe the bug
In NativeAppBar position is fixed which is hard coded, which is a bad practice, which can be passed using prop.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'NativeAppBar.js'

Expected behavior
Position should be passed using props.

Stack Trace

Screenshots

Desktop (please complete the following information):

  • OS: [Windows]
  • Browser [Chrome]
  • Version [Version 126.0.6478.183 (Official Build) (64-bit)]

Additional context
@PritamBag PritamBag added the enhancement New feature or request label Sep 4, 2024
@PritamBag PritamBag self-assigned this Sep 4, 2024
@PritamBag PritamBag mentioned this issue Sep 4, 2024
Merged
8 tasks
PritamBag added a commit that referenced this issue Sep 4, 2024
@PritamBag
fix(global): 🐛 update NativeAppBar code
0fa3746 
here position is write in hardcoded, that is not needed, we can pass position in prop

Ref: #121
@PritamBag PritamBag mentioned this issue Sep 4, 2024
Merged
8 tasks
PritamBag added a commit that referenced this issue Sep 9, 2024
@PritamBag
refactor(global): ♻️ update code of NativeAppBar as commented
d430738 
in NativeAppBar there is need of few changes, So I updated the changes

Ref: #121
@PritamBag
Copy link
Member Author

Closing as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PritamBag PritamBag

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

WRPD-enhancement-121 wrappid/native-web
1 participant
@PritamBag