Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: dataDisplay/CoreTable related CoreComponents prop sanitization #339

Merged
merged 7 commits into from
Sep 4, 2024
Merged

bugfix: dataDisplay/CoreTable related CoreComponents prop sanitization #339

merged 7 commits into from
Sep 4, 2024

Conversation

anantakumarghosh
Copy link
Member

@anantakumarghosh anantakumarghosh commented Aug 28, 2024 •
edited
Loading

Description

This PR adds valid props and prop sanitizations for below listed CoreComponents:

  • CoreTable
  • CoreTableBody
  • CoreTableCell
  • CoreTableContainer
  • CoreTableFooter
  • CoreTableHead
  • CoreTablePagination
  • CoreTableRow
  • CoreTableSortLabel

Ref: #336

Related Issues

Testing

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Additional Notes

Reviewers

Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

@anantakumarghosh anantakumarghosh linked an issue Aug 28, 2024 that may be closed by this pull request
bug: dataDisplay/CoreTable valid props and sanitization. #336
Open
12 tasks
@anantakumarghosh anantakumarghosh changed the base branch from main to development August 28, 2024 11:16
@anantakumarghosh
fix(global): 🐛 add valid props for all CoreTable related components
c48b82e 
add valid props and sanitizations for all CoreTable related components

ref: #336
techoneel
techoneel requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the following changes:

  1. Remove unnecessary destructure
  2. Self closing tag
  3. component default value can be removed if problem appears then put it inside default value

package/components/dataDisplay/CoreTable.js Outdated Show resolved Hide resolved
package/components/dataDisplay/CoreTableBody.js Outdated Show resolved Hide resolved
package/components/dataDisplay/CoreTableContainer.js Outdated Show resolved Hide resolved
package/components/dataDisplay/CoreTableFooter.js Outdated Show resolved Hide resolved
package/components/dataDisplay/CoreTablePagination.js Show resolved Hide resolved
@anantakumarghosh anantakumarghosh self-assigned this Aug 29, 2024
techoneel
techoneel previously requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do the needed changes or added todo

package/components/dataDisplay/CoreTable.js Show resolved Hide resolved
@anantakumarghosh anantakumarghosh added bug Something isn't working bugfix Pull Requests that fixes a bug and removed bug Something isn't working labels Aug 30, 2024
@anantakumarghosh anantakumarghosh changed the title bugifix: dataDisplay/CoreTable related CoreComponents prop sanitization bugfix: dataDisplay/CoreTable related CoreComponents prop sanitization Aug 30, 2024
@anantakumarghosh anantakumarghosh dismissed techoneel’s stale review August 30, 2024 09:33

changes implemented.

techoneel
techoneel approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@techoneel techoneel merged commit 4fbdb2e into development Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techoneel techoneel techoneel approved these changes

Assignees

@anantakumarghosh anantakumarghosh

Labels
bugfix Pull Requests that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: dataDisplay/CoreTable valid props and sanitization.
2 participants
@anantakumarghosh @techoneel