Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: NotificationPopOver is not designed properly #373

Open
3 tasks
arkaprota opened this issue Sep 17, 2024 · 1 comment · May be fixed by #374
Open
3 tasks

bug: NotificationPopOver is not designed properly #373

arkaprota opened this issue Sep 17, 2024 · 1 comment · May be fixed by #374
Assignees
@arkaprota
Labels
bug Something isn't working bugfix Pull Requests that fixes a bug

Comments

@arkaprota
Copy link
Member

Describe the bug

  • NotificationPopOver is not designed properly
  • the icon is changed
  • the heading alignment is not given properly

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Stack Trace
The stack trace of the bug if any.

Screenshots

Screenshot 2024-09-17 152118

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@arkaprota arkaprota self-assigned this Sep 17, 2024
@arkaprota arkaprota added bug Something isn't working bugfix Pull Requests that fixes a bug labels Sep 17, 2024
arkaprota added a commit that referenced this issue Sep 17, 2024
@arkaprota
fix(core): 🐛 notificationpopover is design is completed properly
3732636 
notificationpopover has been fixed

Ref: #373
@arkaprota arkaprota linked a pull request Sep 17, 2024 that will close this issue
Open
3 tasks
@techoneel
Copy link
Member

I do not think the icon will change it's a clear all icon.
@arkaprota please suggest a design first then start changing the code.

arkaprota added a commit that referenced this issue Sep 23, 2024
@arkaprota
fix(global): 🐛 change the coreicon more_horiz to clear_all which was …
a4885b6 
…previouly given

the coreicon more_horiz to clear_all which was there previouly was been required is solved

Ref: #373
@arkaprota arkaprota linked a pull request Oct 14, 2024 that will close this issue
fix(core): 🐛 notificationpopover is design is completed properly #374
Open
3 tasks
arkaprota added a commit that referenced this issue Oct 22, 2024
@arkaprota
fix(core): 🐛 remove the sx
45a8b89 
remove the sx property

Ref: #373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkaprota arkaprota

Labels
bug Something isn't working bugfix Pull Requests that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): 🐛 notificationpopover is design is completed properly wrappid/core
2 participants
@techoneel @arkaprota