Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codebase to remove unnecessary applyWpFilters() and doWpAction() #893

Open
raamdev opened this issue May 27, 2017 · 0 comments
Open

Refactor codebase to remove unnecessary applyWpFilters() and doWpAction() #893

raamdev opened this issue May 27, 2017 · 0 comments
Assignees
@raamdev
Labels
todo
Milestone
Future Release

Comments

@raamdev
Copy link
Contributor

raamdev commented May 27, 2017

@jaswrks writes...

now that we are beyond the point of needing to support back compat. for ZenCache hooks, we should probably update the codebase. At some point we can convert all calls to applyWpFilters() to just apply_filters(). The same for doWpAction(), which can just be do_action().

Beyond that, at some point we should do another review of the AC plugin hook system in Comet Cache, because now that WordPress is exposing the standard WP hook/filter library in the early phase, we shouldn't need that any longer.
@raamdev raamdev added the todo label May 27, 2017
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue May 27, 2017
@raamdev
Preparing pull request. See: wpsharks/comet-cache#893
e09fd30
@raamdev raamdev mentioned this issue May 27, 2017
Open
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue May 27, 2017
@raamdev
Replace applyWpFilters() with apply_filters()
6f99eef 
 Now that WordPress is exposing the standard WP hook/filter library in
 the early phase, we don't need our own method for this.

 This also drops backwards compatibility with ZenCache filters.
 ZenCache has not been supported for more than a year now.

 See wpsharks/comet-cache#893
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue May 27, 2017
@raamdev
Replace doWpAction() with do_action()
0036143 
 Now that WordPress is exposing the standard WP hook/filter library in
 the early phase, we don't need our own method for this.

 This also drops backwards compatibility with ZenCache actions.
 ZenCache has not been supported for more than a year now.

 See wpsharks/comet-cache#893
@raamdev raamdev added this to the Next Release milestone May 29, 2017
@raamdev raamdev self-assigned this May 29, 2017
@raamdev raamdev modified the milestones: Next Release, Future Release Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raamdev raamdev

Labels
todo
Projects
None yet
Milestone
Future Release
Development

No branches or pull requests
1 participant
@raamdev