Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Cache Pro not working when on Gravity Forms #272

Closed
seozones opened this issue Aug 13, 2014 · 24 comments
Closed

Quick Cache Pro not working when on Gravity Forms #272

seozones opened this issue Aug 13, 2014 · 24 comments

Comments

@seozones
Copy link

Hi there. I am using the Quick Cache Pro plugin on my site but the clear cache button at top does not function when on any of the Gravity Forms menu tabs inside the dashboard. it works just fine when I'm anywhere else inside the wp dashboard area just on Forms. Any ideas on how to get that to work?

@raamdev
Copy link
Contributor

raamdev commented Aug 18, 2014

Since Gravity Forms is a premium plugin (not free), I have no way of testing this. It sounds like there's a JavaScript conflict somewhere.

If you're using the Firefox or Chrome browser, could you open up the JavaScript console (View → Developer → JavaScript Console on Chrome) and then attempt to click the Clear Cache button again? If there's a JavaScript conflict somewhere, the console should show some information that might be helpful. If you can get me a screenshot of that, that would be great.

@seozones
Copy link
Author

Okay, here you go.

On 2014-08-18 13:38, Raam Dev wrote:

Since Gravity Forms is a premium plugin (not free), I have no way of
testing this. It sounds like there's a JavaScript conflict somewhere.

If you're using the Firefox or Chrome browser, could you open up the
JavaScript console (VIEW → DEVELOPER → JAVASCRIPT CONSOLE on
Chrome) and then attempt to click the Clear Cache button again? If
there's a JavaScript conflict somewhere, the console should show some
information that might be helpful. If you can get me a screenshot of
that, that would be great.

Reply to this email directly or view it on GitHub [1].

Links:

[1]
#272 (comment)

Thanks, Mike
(720) 891-1371

@raamdev
Copy link
Contributor

raamdev commented Aug 19, 2014

Okay, here you go.

I'm not sure if there was supposed to be an image attached there, but you cannot attach images to GitHub replies via email; you must login to the web interface and drag-n-drop the image into the composition box.

@seozones
Copy link
Author

okay, sorry here you go Raam.

gravity forms and quick cache pro

@jaswrks
Copy link

jaswrks commented Aug 19, 2014

This error makes me think one of the following is occurring...

  • Something (i.e. a plugin/theme conflict) is preventing QC from injecting <meta property="quick_cache:vars" content="data-json" data-json="{&quot;ajaxURL&quot;:&quot;... into the HEAD section of your site on certain pages.
  • Or, that there is a JavaScript error in pages where this is occurring, preventing QC-driven routines from working as they normally would.
  • The HTML on certain pages contains an invalid nesting order; i.e. a corrupted DOM.

Can I get a link to a page where this is occurring please?

@seozones
Copy link
Author

Hi Jason. This is occurring in the wp dashboard area where I have both quick cache pro and gravity forms installed. When I click on Forms inside the dashboard, the Clear Cache button up top does not work - doesn't do anything. Where can I send you a login so you can see for yourself?

@jaswrks
Copy link

jaswrks commented Aug 19, 2014

Gotcha :-) You can submit that privately here please.
http://wsharks.com/1tj9G6D

@seozones
Copy link
Author

okay Jason, that ticket was created: #3537

@jaswrks
Copy link

jaswrks commented Aug 19, 2014

Thank you! It looks like this could be a QC bug actually. I fixed this in your installation. Please refresh your browser while inside the WP Dashboard. Then try again :-)


Bug Report

This line should be moved into the onReady() handler for the best compatibility.

@seozones
Copy link
Author

Yea, it works!!! :)

Do I need to update the QC Pro plugin on my other sites that have it
installed?

Also, I've been clearing the cache every time I enter the dashboard.
Not sure if that is something I should be doing. I want to make sure
that site visitors who have downloaded files will not have to
re-download them again if possible. With the Pro version is there a
tutorial or video series I can read or watch concerning this?

On 2014-08-19 15:16, JasWSInc wrote:

Thank you! It looks like this could be a QC bug actually. I fixed this
in your installation. Please refresh your browser while inside the WP

Dashboard. Then try again :-)

BUG REPORT

This line [1] should be moved into the onReady() handler for the best
compatibility.

Reply to this email directly or view it on GitHub [2].

Links:

[1]
https://github.com/websharks/quick-cache-pro/blob/000000-dev/quick-cache-pro/client-s/js/admin-bar.js#L7
[2]
#272 (comment)

Thanks, Mike
(720) 891-1371

@jaswrks
Copy link

jaswrks commented Aug 19, 2014

Do I need to update the QC Pro plugin on my other sites that have it
installed?

Yes, you can do that if you like. Just copy the files from that installation I just worked on to your other sites to correct the issue. It's one specific file actually: /wp-content/plugins/quick-cache-pro/client-s/js/admin-bar.min.js

Also, I've been clearing the cache every time I enter the dashboard.
Not sure if that is something I should be doing. I want to make sure
that site visitors who have downloaded files will not have to
re-download them again if possible. With the Pro version is there a
tutorial or video series I can read or watch concerning this?

No, that should not be necessary. It doesn't really hurt anything either though.

No video series yet. There are a few videos circulating YouTube but we have yet done anything formal in this regard. I believe it's on the TODO list though :-) There is a Wiki. See: https://github.com/websharks/quick-cache/wiki

@seozones
Copy link
Author

Okay, thanks Jason. Will that change that you made be on the next
automatic update?

On 2014-08-19 15:44, JasWSInc wrote:

Do I need to update the QC Pro plugin on my other sites that have it
installed?

Yes, you can do that if you like. Just copy the files from that
installation I just worked on to your other sites to correct the
issue. It's one specific file actually:
/wp-content/plugins/quick-cache-pro/client-s/js/admin-bar.min.js

Also, I've been clearing the cache every time I enter the dashboard.
Not sure if that is something I should be doing. I want to make
sure
that site visitors who have downloaded files will not have to
re-download them again if possible. With the Pro version is there a
tutorial or video series I can read or watch concerning this?

No, that should not be necessary. It doesn't really hurt anything
either though.

No video series yet. There are a few videos circulating YouTube but we
have yet done anything formal in this regard. I believe it's on the
TODO list though :-) There is a Wiki. See:
https://github.com/websharks/quick-cache/wiki [1]

Reply to this email directly or view it on GitHub [2].

Links:

[1] https://github.com/websharks/quick-cache/wiki
[2]
#272 (comment)

Thanks, Mike
(720) 891-1371

@jaswrks
Copy link

jaswrks commented Aug 19, 2014

That is very likely, yes. I can't promise that it will, but it's been filed now and it's a simple fix. I suspect it will go out with the next release. If not, the one after the next.

@seozones
Copy link
Author

Okay, thanks Jason. On a side note, do you offer an affiliate program
for your quick cache pro version?

On 2014-08-19 16:21, JasWSInc wrote:

That is very likely, yes. I can't promise that it will, but it's been
filed now and it's a simple fix. I suspect it will go out with the
next release. If not, the one after the next.

Reply to this email directly or view it on GitHub [1].

Links:

[1]
#272 (comment)

Thanks, Mike
(720) 891-1371

@jaswrks
Copy link

jaswrks commented Aug 19, 2014

Hey! Thanks for the interest. Yes, we'd love to have you on board with us. You can get signed up here. You'll find links for both s2Member and for Quick Cache Pro here: https://affiliates.websharks-inc.com/

@seozones
Copy link
Author

Okay, I have a login but don't see any banners for Quick Cache Pro
inside the affiliate area. I am interested in selling that product at
the moment.

On 2014-08-19 17:51, JasWSInc wrote:

Hey! Thanks for the interest. Yes, we'd love to have you on board with
us. You can get signed up here. You'll find links for both s2Member
and for Quick Cache Pro here: https://affiliates.websharks-inc.com/
[1]

Reply to this email directly or view it on GitHub [2].

Links:

[1] https://affiliates.websharks-inc.com/
[2]
#272 (comment)

Thanks, Mike
(720) 891-1371

@jaswrks
Copy link

jaswrks commented Aug 20, 2014

There are text links for Quick Cache Pro here inside your account.
https://affiliates.websharks-inc.com/account.php?page=9

QC was added to this program only a short while back. No official banners yet, but you are welcomed to use any of the images from this page; and of course you could take screenshots of the app itself. Videos like this one are also a great way to cash in. See: http://jaswsinc.com/quick-cache-wordpress-cache-plugin/

You're welcome to republish that video even, if you want to.

@jaswrks
Copy link

jaswrks commented Aug 20, 2014

Product page: http://www.websharks-inc.com/product/quick-cache/
~ You can grab that banner if you like.

@jaswrks
Copy link

jaswrks commented Aug 20, 2014

You can grab the embed code for that video here by clicking the "Share" button below the video.
https://www.youtube.com/watch?v=XHduTfeABFY

@raamdev raamdev added this to the Next Release milestone Aug 20, 2014
@raamdev raamdev self-assigned this Aug 20, 2014
@raamdev
Copy link
Contributor

raamdev commented Aug 20, 2014

@jaswsinc Thanks for confirming this bug!

@seozones I'll get this fixed for the next release. Thank you for reporting this bug!

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Aug 20, 2014

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@raamdev
Copy link
Contributor

raamdev commented Aug 20, 2014

Next release changelog:

@jaswrks
Copy link

jaswrks commented Aug 20, 2014

Thanks @raamdev 👍

@seozones
Copy link
Author

Thanks guys!!!

On 2014-08-19 18:25, Raam Dev wrote:

@jaswsinc [1] Thanks for confirming this bug!

@seozones [2] I'll get this fixed for the next release. Thank you for
reporting this bug!

Reply to this email directly or view it on GitHub [3].

Links:

[1] https://github.com/jaswsinc
[2] https://github.com/seozones
[3]
#272 (comment)

Thanks, Mike
(720) 891-1371

@seozones
Copy link
Author

Okay, thanks Jason.

On 2014-08-19 18:18, JasWSInc wrote:

There are text links for Quick Cache Pro here inside your account.
https://affiliates.websharks-inc.com/account.php?page=9 [1]

QC was added to this program only a short while back. No official
banners yet, but you are welcomed to use any of the images from this
page; and of course you could take screenshots of the app itself.
Videos like this one are also a great way to cash in. See:
http://jaswsinc.com/quick-cache-wordpress-cache-plugin/ [2]

You're welcome to republish that video even, if you want to.

Reply to this email directly or view it on GitHub [3].

Links:

[1] https://affiliates.websharks-inc.com/account.php?page=9
[2] http://jaswsinc.com/quick-cache-wordpress-cache-plugin/
[3]
#272 (comment)

Thanks, Mike
(720) 891-1371

@raamdev raamdev removed their assignment Apr 28, 2016
raamdev added a commit that referenced this issue Sep 17, 2016

Verified

This commit was signed with the committer’s verified signature.
raamdev Raam Dev
- **New Feature** (Lite): The Clear Cache button is now available in the Admin Toolbar for the Lite version of Comet Cache.
- **New Feature** (Pro): Comet Cache Pro is now fully compatible with [WordPress Automatic Background Updates](https://codex.wordpress.org/Configuring_Automatic_Background_Updates#Plugin_.26_Theme_Updates_via_Filter). If you enable automatic background updates for plugins, and you save valid Comet Cache Pro License Credentials in the _Comet Cache Pro → Plugin Options → Update Credentials_ panel, you will automatically receive Pro plugin updates. Props @jaswsinc. See [Issue #289](#289).
- **Bug Fix**: In some scenarios Comet Cache might produce a false-positive "Warning: mkdir(): File exists" message when checking if the cache directory exists. Comet Cache now calls `clearstatcache()` and uses `file_exists()` instead of `is_dir()` to help make this check more robust. See [Issue #786](#786).
- **Bug Fix**: Fixed a bug where the Comet Cache PHP requirements check would fail and produce a fatal error when upgrading from a version of Comet Cache that did not require an extension that is now required by newer releases. This would occur when, for example, the required PHP `mbstring` extension was missing. Props @jaswsinc for finding the bug. See [Issue #817](#817).
- **Bug Fix**: Fixed a bug where upgrading from v160521 would result in the Client-Side Cache option being reset to the default (disabled). If you enabled the Client-Side Cache at some point, now is a good time to double-check that it's still enabled. This bug fix also improves the reliability of all version upgrade routines that Comet Cache runs during upgrades. See [Issue #807](#807).
- **Compatibility / Bug Fix**: The automatic Clear Cache routines that cleared the entire cache automatically whenever _WordPress Dashboard → Settings → General_ was updated, were being too aggressive and not taking into consideration other plugins that might also be using the same `options-general.php` URL. As a result, the entire cache was being unnecessarily cleared when the settings for those other plugins were saved. Props to @futtta from Autoptimize for reporting. See [Issue #825](#825).
- **UI Enhancement:** Adjusted option page font styles for WordPress v4.6 to better match existing style. See [Issue #271](wpsharks/comet-cache-pro#271).
- **ManageWP Compatibility** (Pro): Comet Cache Pro is now compatible with ManageWP, a service that allows remote management of multiple WordPress sites. Comet Cache Pro Plugin Updates will now appear in the ManageWP dashboard and, assuming you have saved valid license credentials in _Dashboard → Comet Cache Pro → Plugin Options → Update Credentials_, you will be able to upgrade Comet Cache Pro remotely from the ManageWP Dashboard. Props @jaswsinc. See [Issue #465](#465).
- **InfiniteWP Compatibility** (Pro): Comet Cache Pro is now compatible with InfiniteWP, an application that allows you to manage multiple WordPress sites from a single location. Comet Cache Pro Plugin Updates will now appear in the InfiniteWP dashboard and, assuming you have saved valid license credentials in _Dashboard → Comet Cache Pro → Plugin Options → Update Credentials_, you will be able to upgrade Comet Cache Pro remotely from the InfiniteWP Dashboard. See [Issue #394](#394).
- **Rewritten Pro Plugin Updater**: The Comet Cache Pro Plugin Updater has been redesigned to use the built-in WordPress plugin updater system. When a Comet Cache Pro update is available, it now appears in the WordPress Updates section and in the Plugins list, like other WordPress plugins and can be updated normally like other WordPress plugins, as long as you have saved valid Comet Cache Pro license details in the new "Update Credentials" options panel. Props @jaswsinc. See [Issue #272](wpsharks/comet-cache-pro#272).
- **Code Style**: The `WP_CACHE` line that gets inserted into the `wp-config.php` file to enable caching now follows the [WordPress PHP Code Standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/). Props @szepeviktor. See [Issue #799](#799).
- **Compatibility** (Pro): When the Autoptimize plugin is active, the Comet Cache Pro HTML Compressor panel now shows a friendly notice explaining that both the HTML Compressor and Autoptimize should not be enabled at the same time because they both address the same performance improvements. The rest of Comet Cache works great alongside Autoptimize and whether you use the HTML Compressor or Autoptimize is a matter of preference. Props to @futtta from Autoptimize for the continued collaboration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants