Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat with PHP CS Fixer #223

Closed
wants to merge 2 commits into from
Closed

Conversation

raamdev
Copy link
Contributor

@raamdev raamdev commented Mar 2, 2016

See wpsharks/comet-cache#635

Ran with php-cs-fixer --config-file=/Users/raam/.php_cs -vvv fix .


$ php-cs-fixer --config-file=/Users/raam/.php_cs -vvv fix .
Loaded config from "/Users/raam/.php_cs"
You are running php-cs-fixer with xdebug enabled. This has a major impact on runtime performance.
I.IIIIIIIIIIIIIIF.FFF.F.FFFFF.FFFFF.FFFF.FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF...
Legend: ?-unknown, I-invalid file syntax, file ignored, .-no changes, F-fixed, E-error
   1) plugin.php (spaces_cast, eof_ending)
   2) src/includes/classes/AbsBase.php (unneeded_control_parentheses, unalign_equals, phpdoc_type_to_var, phpdoc_var_to_type, short_array_syntax, align_equals)
   3) src/includes/classes/AbsBaseAp.php (single_line_after_imports, unalign_equals, align_equals)
   4) src/includes/classes/Actions.php (unalign_equals, unalign_double_arrow, spaces_cast, short_array_syntax, align_equals, align_double_arrow)
   5) src/includes/classes/AdvCacheBackCompat.php (unalign_equals, unalign_double_arrow, short_array_syntax, align_double_arrow)
   6) src/includes/classes/AutoCache.php (unalign_equals, phpdoc_type_to_var, unalign_double_arrow, phpdoc_var_to_type, short_array_syntax, align_equals, align_double_arrow)
   7) src/includes/classes/CdnFilters.php (unalign_equals, phpdoc_type_to_var, unalign_double_arrow, phpdoc_var_to_type, short_array_syntax, align_equals, align_double_arrow)
   8) src/includes/classes/Conflicts.php (unneeded_control_parentheses, unalign_equals, short_array_syntax, align_equals)
   9) src/includes/classes/DirStats.php (unalign_equals, phpdoc_type_to_var, phpdoc_var_to_type, short_array_syntax, align_equals)
  10) src/includes/classes/FeedUtils.php (unalign_equals, phpdoc_type_to_var, phpdoc_var_to_type, short_array_syntax, align_equals)
  11) src/includes/classes/MenuPageOptions.php (short_array_syntax)
  12) src/includes/classes/MenuPageProUpdater.php (short_array_syntax)
  13) src/includes/classes/MenuPageStats.php (short_array_syntax)
  14) src/includes/classes/Plugin.php (function_declaration, single_line_after_imports, unalign_equals, phpdoc_type_to_var, unalign_double_arrow, phpdoc_var_to_type, short_array_syntax, align_equals, align_double_arrow)
  15) src/includes/classes/VsUpgrades.php (unalign_equals, phpdoc_type_to_var, braces, phpdoc_var_to_type, short_array_syntax, align_equals)
  16) src/includes/functions/wp-cache-postload.php (unalign_equals, short_array_syntax, align_equals)
  17) src/includes/interfaces/Shared/CachePathConsts.php (no_blank_lines_after_class_opening, phpdoc_type_to_var, braces, phpdoc_var_to_type)
  18) src/includes/interfaces/Shared/NcDebugConsts.php (no_blank_lines_after_class_opening, phpdoc_type_to_var, braces, phpdoc_var_to_type)
  19) src/includes/plugin.php (function_declaration, unalign_equals, align_equals)
  20) src/includes/traits/Ac/AbortUtils.php (braces)
  21) src/includes/traits/Ac/AcPluginUtils.php (unalign_equals, braces, align_equals)
  22) src/includes/traits/Ac/BrowserUtils.php (phpdoc_indent, braces)
  23) src/includes/traits/Ac/HtmlCUtils.php (unalign_equals, unalign_double_arrow, braces, align_equals, align_double_arrow)
  24) src/includes/traits/Ac/NcDebugUtils.php (phpdoc_type_to_var, braces, phpdoc_var_to_type)
  25) src/includes/traits/Ac/ObUtils.php (phpdoc_scalar, no_blank_lines_after_class_opening, unalign_equals, phpdoc_type_to_var, braces, phpdoc_var_to_type, align_equals)
  26) src/includes/traits/Ac/PostloadUtils.php (unalign_equals, phpdoc_type_to_var, unalign_double_arrow, braces, phpdoc_var_to_type, align_equals, align_double_arrow)
  27) src/includes/traits/Ac/ShutdownUtils.php (braces)
  28) src/includes/traits/Plugin/ActionUtils.php (braces)
  29) src/includes/traits/Plugin/AdminBarUtils.php (phpdoc_scalar, unalign_equals, unalign_double_arrow, braces, align_equals, align_double_arrow)
  30) src/includes/traits/Plugin/AutoCacheUtils.php (unalign_equals, braces, align_equals)
  31) src/includes/traits/Plugin/BbPressUtils.php (unalign_equals, braces, align_equals)
  32) src/includes/traits/Plugin/CdnUtils.php (no_blank_lines_after_class_opening, braces)
  33) src/includes/traits/Plugin/CleanupUtils.php (braces)
  34) src/includes/traits/Plugin/CondUtils.php (braces)
  35) src/includes/traits/Plugin/CronUtils.php (unalign_double_arrow, braces, align_double_arrow)
  36) src/includes/traits/Plugin/DbUtils.php (braces)
  37) src/includes/traits/Plugin/DirUtils.php (phpdoc_short_description, unalign_equals, braces, align_equals)
  38) src/includes/traits/Plugin/HtaccessUtils.php (phpdoc_indent, phpdoc_scalar, phpdoc_short_description, unalign_equals, phpdoc_params, braces, align_equals)
  39) src/includes/traits/Plugin/HtmlCUtils.php (braces)
  40) src/includes/traits/Plugin/InstallUtils.php (no_blank_lines_after_class_opening, unalign_equals, unalign_double_arrow, braces, align_equals, align_double_arrow)
  41) src/includes/traits/Plugin/MenuPageUtils.php (phpdoc_scalar, unalign_equals, phpdoc_type_to_var, unalign_double_arrow, braces, phpdoc_var_to_type, align_equals, align_double_arrow)
  42) src/includes/traits/Plugin/NoticeUtils.php (phpdoc_indent, phpdoc_scalar, phpdoc_separation, unalign_equals, unalign_double_arrow, phpdoc_params, braces, align_equals, align_double_arrow)
  43) src/includes/traits/Plugin/OptionUtils.php (unalign_equals, braces, align_equals)
  44) src/includes/traits/Plugin/PostUtils.php (braces)
  45) src/includes/traits/Plugin/StatsUtils.php (unalign_equals, unalign_double_arrow, braces, align_equals, align_double_arrow)
  46) src/includes/traits/Plugin/UpdateUtils.php (unalign_equals, unalign_double_arrow, braces, align_equals, align_double_arrow)
  47) src/includes/traits/Plugin/UrlUtils.php (braces)
  48) src/includes/traits/Plugin/UserUtils.php (unneeded_control_parentheses, phpdoc_indent, phpdoc_scalar, phpdoc_short_description, braces)
  49) src/includes/traits/Plugin/WcpAuthorUtils.php (pre_increment, unalign_equals, braces, align_equals)
  50) src/includes/traits/Plugin/WcpCdnUtils.php (phpdoc_scalar, phpdoc_params, braces)
  51) src/includes/traits/Plugin/WcpCommentUtils.php (braces)
  52) src/includes/traits/Plugin/WcpEvalUtils.php (unneeded_control_parentheses, phpdoc_scalar, no_blank_lines_after_class_opening, phpdoc_params, braces)
  53) src/includes/traits/Plugin/WcpFeedUtils.php (unalign_equals, braces, align_equals)
  54) src/includes/traits/Plugin/WcpHomeBlogUtils.php (unalign_equals, braces, align_equals)
  55) src/includes/traits/Plugin/WcpHtmlCUtils.php (unalign_equals, braces, align_equals)
  56) src/includes/traits/Plugin/WcpJetpackUtils.php (braces)
  57) src/includes/traits/Plugin/WcpOpcacheUtils.php (phpdoc_scalar, phpdoc_params, braces)
  58) src/includes/traits/Plugin/WcpPluginUtils.php (phpdoc_indent, braces)
  59) src/includes/traits/Plugin/WcpPostTypeUtils.php (braces)
  60) src/includes/traits/Plugin/WcpPostUtils.php (unalign_equals, braces, align_equals)
  61) src/includes/traits/Plugin/WcpS2cleanUtils.php (phpdoc_scalar, phpdoc_params, braces)
  62) src/includes/traits/Plugin/WcpSettingUtils.php (unalign_equals, braces, align_equals)
  63) src/includes/traits/Plugin/WcpSitemapUtils.php (no_blank_lines_after_class_opening, braces)
  64) src/includes/traits/Plugin/WcpTermUtils.php (unalign_equals, braces, align_equals)
  65) src/includes/traits/Plugin/WcpTransientUtils.php (phpdoc_indent, phpdoc_scalar, unalign_equals, phpdoc_params, align_equals)
  66) src/includes/traits/Plugin/WcpUpdaterUtils.php (unalign_equals, braces, align_equals)
  67) src/includes/traits/Plugin/WcpUrlUtils.php (phpdoc_indent, braces)
  68) src/includes/traits/Plugin/WcpUserUtils.php (phpdoc_indent, phpdoc_params, braces)
  69) src/includes/traits/Plugin/WcpUtils.php (phpdoc_type_to_var, braces, phpdoc_var_to_type)
  70) src/includes/traits/Plugin/WcpWooCommerceUtils.php (braces)
  71) src/includes/traits/Shared/BlogUtils.php (phpdoc_scalar, braces)
  72) src/includes/traits/Shared/CacheDirUtils.php (phpdoc_scalar, phpdoc_separation, unalign_equals, phpdoc_params, braces, phpdoc_order, align_equals)
  73) src/includes/traits/Shared/CacheLockUtils.php (phpdoc_separation, unalign_equals, phpdoc_params, braces, phpdoc_order, align_equals)
  74) src/includes/traits/Shared/CachePathUtils.php (unneeded_control_parentheses, phpdoc_indent, phpdoc_separation, unalign_equals, phpdoc_params, braces, align_equals)
  75) src/includes/traits/Shared/ConditionalUtils.php (unneeded_control_parentheses, phpdoc_scalar, unalign_equals, phpdoc_type_to_var, unalign_double_arrow, braces, phpdoc_var_to_type, align_equals, align_double_arrow)
  76) src/includes/traits/Shared/DomainMappingUtils.php (unneeded_control_parentheses, phpdoc_scalar, phpdoc_separation, unalign_equals, phpdoc_params, braces, align_equals)
  77) src/includes/traits/Shared/EscapeUtils.php (phpdoc_scalar, phpdoc_params, braces)
  78) src/includes/traits/Shared/FsUtils.php (unneeded_control_parentheses, phpdoc_scalar, phpdoc_separation, unalign_equals, unalign_double_arrow, phpdoc_params, braces, phpdoc_var_to_type, align_equals, align_double_arrow)
  79) src/includes/traits/Shared/HookUtils.php (phpdoc_scalar, unalign_equals, phpdoc_type_to_var, unalign_double_arrow, phpdoc_params, braces, phpdoc_order, phpdoc_var_to_type, align_equals, align_double_arrow)
  80) src/includes/traits/Shared/HttpUtils.php (phpdoc_indent, phpdoc_scalar, unalign_equals, braces, align_equals)
  81) src/includes/traits/Shared/I18nUtils.php (phpdoc_scalar, braces)
  82) src/includes/traits/Shared/IpAddrUtils.php (unneeded_control_parentheses, braces)
  83) src/includes/traits/Shared/PatternUtils.php (unalign_equals, braces, align_equals)
  84) src/includes/traits/Shared/ReplaceUtils.php (phpdoc_scalar, phpdoc_separation, unalign_equals, phpdoc_params, braces, align_equals)
  85) src/includes/traits/Shared/ServerUtils.php (unneeded_control_parentheses, braces)
  86) src/includes/traits/Shared/StringUtils.php (unalign_equals, braces, align_equals)
  87) src/includes/traits/Shared/SysUtils.php (unneeded_control_parentheses, phpdoc_scalar, unalign_equals, braces, align_equals)
  88) src/includes/traits/Shared/TokenUtils.php (unneeded_control_parentheses, phpdoc_scalar, phpdoc_separation, phpdoc_type_to_var, phpdoc_params, braces, phpdoc_var_to_type, align_equals)
  89) src/includes/traits/Shared/TrimUtils.php (phpdoc_separation, unalign_equals, phpdoc_params, braces, align_equals)
  90) src/includes/traits/Shared/UrlUtils.php (unneeded_control_parentheses, phpdoc_scalar, unalign_equals, braces, align_equals)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@raamdev
Copy link
Contributor Author

raamdev commented Mar 2, 2016

@jaswsinc A review please.

This should resolve the conversion from array() to the short syntax [].

Also, PhpStorm caught an error in src/includes/traits/Shares/FsUtils.php where $_sub_path is not defined. Is that supposed to be $_resource_sub_path?

@jaswrks
Copy link
Contributor

jaswrks commented Mar 2, 2016

Looks great! :-)

This should resolve the conversion from array() to the short syntax [].

Cool.

Also, PhpStorm caught an error in src/includes/traits/Shares/FsUtils.php where $_sub_path is not defined. Is that supposed to be $_resource_sub_path?

Yes, that does look like a bug. Great catch!

@raamdev raamdev closed this Mar 4, 2016
@raamdev raamdev deleted the feature/635-reformat branch March 4, 2016 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants