Skip to content
Codes review

@wpmudev/sui-icons types #157

Sign in to view logs

@wpmudev/sui-icons types

@wpmudev/sui-icons types #157

Triggered via pull request October 19, 2023 09:49
@abderabder
synchronize #149
sui-icons-package-types-fix
Status Failure
Total duration 12m 27s
Artifacts –

code-review.yml

on: pull_request
setup-env
4m 9s
setup-env
code-testing
7m 43s
code-testing
code-linting
6m 22s
code-linting
cleanup-env
5s
cleanup-env
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 8 warnings
code-linting: packages/components/alert-banner/src/alert-banner.tsx#L4
No default export found in imported module "@wpmudev/sui-icons"
code-linting: packages/components/builder/__tests__/builder.test.tsx#L22
'action' is missing in props validation
code-linting: packages/components/builder/__tests__/builder.test.tsx#L29
'action' is missing in props validation
code-linting: packages/components/builder/__tests__/builder.test.tsx#L36
'action' is missing in props validation
code-linting: packages/components/builder/__tests__/builder.test.tsx#L44
'action' is missing in props validation
code-linting: packages/components/builder/__tests__/builder.test.tsx#L52
'action' is missing in props validation
code-linting: packages/components/builder/__tests__/builder.test.tsx#L55
'customContent' is missing in props validation
code-linting: packages/components/builder/__tests__/builder.test.tsx#L60
'action' is missing in props validation
code-linting: packages/components/builder/__tests__/builder.test.tsx#L61
'accordionTitle' is missing in props validation
code-linting: packages/components/builder/__tests__/builder.test.tsx#L64
'accordionBody' is missing in props validation
code-testing
Process completed with exit code 1.
code-linting: packages/components/code-editor/__tests__/code-editor.test.tsx#L8
Test has no assertions
code-linting: packages/components/code-editor/__tests__/code-editor.test.tsx#L9
Some tests seem to be commented
code-linting: packages/components/color-picker/__tests__/color-picker.test.tsx#L19
Test has no assertions
code-linting: packages/components/color-picker/src/color-picker.tsx#L40
React Hook useEffect has a missing dependency: 'tempColor'. Either include it or remove the dependency array
code-linting: packages/components/color-picker/src/color-picker.tsx#L62
React Hook useCallback has an unnecessary dependency: 'color'. Either exclude it or remove the dependency array
code-linting: packages/components/color-picker/src/color-picker.tsx#L71
React Hook useCallback has an unnecessary dependency: 'tempColor'. Either exclude it or remove the dependency array
code-linting: packages/components/notification/src/notification.tsx#L35
React Hook useEffect has a missing dependency: 'isDismissible'. Either include it or remove the dependency array
cleanup-env
The following actions uses node12 which is deprecated and will be forced to run on node16: geekyeggo/delete-artifact@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/