✨ new(design): design check of components. #110
creador-dev
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
code-review.yml
on: pull_request
Annotations
10 errors and 11 warnings
|
code-linting:
packages/common/advanced/src/index.ts#L2
'@wpmudev/sui-dropdown' should be listed in the project's dependencies. Run 'npm i -S @wpmudev/sui-dropdown' to add it
|
|
code-linting:
packages/common/advanced/src/index.ts#L3
'@wpmudev/sui-notification' should be listed in the project's dependencies. Run 'npm i -S @wpmudev/sui-notification' to add it
|
|
code-linting:
packages/common/collections/src/index.ts#L2
'@wpmudev/sui-button' should be listed in the project's dependencies. Run 'npm i -S @wpmudev/sui-button' to add it
|
|
code-linting:
packages/common/collections/src/index.ts#L4
'@wpmudev/sui-avatar' should be listed in the project's dependencies. Run 'npm i -S @wpmudev/sui-avatar' to add it
|
|
code-linting:
packages/common/collections/src/index.ts#L5
'@wpmudev/sui-tag' should be listed in the project's dependencies. Run 'npm i -S @wpmudev/sui-tag' to add it
|
|
code-linting:
packages/common/core/src/index.ts#L1
'@wpmudev/sui-grid' should be listed in the project's dependencies. Run 'npm i -S @wpmudev/sui-grid' to add it
|
|
code-linting:
packages/common/forms/src/index.ts#L2
'@wpmudev/sui-button' should be listed in the project's dependencies. Run 'npm i -S @wpmudev/sui-button' to add it
|
|
code-linting:
packages/common/forms/src/index.ts#L4
'@wpmudev/sui-avatar' should be listed in the project's dependencies. Run 'npm i -S @wpmudev/sui-avatar' to add it
|
|
code-linting:
packages/common/forms/src/index.ts#L5
'@wpmudev/sui-tag' should be listed in the project's dependencies. Run 'npm i -S @wpmudev/sui-tag' to add it
|
|
code-linting:
packages/common/modules/src/index.ts#L2
'@wpmudev/sui-button' should be listed in the project's dependencies. Run 'npm i -S @wpmudev/sui-button' to add it
|
|
code-linting:
packages/components/code-editor/__tests__/code-editor.test.tsx#L8
Test has no assertions
|
|
code-linting:
packages/components/code-editor/__tests__/code-editor.test.tsx#L9
Some tests seem to be commented
|
|
code-linting:
packages/components/color-picker/__tests__/color-picker.test.tsx#L19
Test has no assertions
|
|
code-linting:
packages/components/color-picker/src/color-picker.tsx#L40
React Hook useEffect has a missing dependency: 'tempColor'. Either include it or remove the dependency array
|
|
code-linting:
packages/components/color-picker/src/color-picker.tsx#L62
React Hook useCallback has an unnecessary dependency: 'color'. Either exclude it or remove the dependency array
|
|
code-linting:
packages/components/color-picker/src/color-picker.tsx#L71
React Hook useCallback has an unnecessary dependency: 'tempColor'. Either exclude it or remove the dependency array
|
|
code-linting:
packages/components/notification/src/notification.tsx#L35
React Hook useEffect has a missing dependency: 'isDismissible'. Either include it or remove the dependency array
|
|
code-linting:
packages/components/search/__tests__/search.test.tsx#L8
Test has no assertions
|
|
code-linting:
packages/components/select/__tests__/select.test.tsx#L31
Test has no assertions
|
|
code-linting:
packages/components/spinner/__tests__/spinner.test.tsx#L62
Some tests seem to be commented
|
|
cleanup-env
The following actions uses node12 which is deprecated and will be forced to run on node16: geekyeggo/delete-artifact@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|