Skip to content

Fixes & Features for the dashboard plugin #1328

Fixes & Features for the dashboard plugin

Fixes & Features for the dashboard plugin #1328

Triggered via pull request November 27, 2024 04:30
Status Failure
Total duration 2m 16s
Artifacts

code-review.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 2 warnings
code-quality
Process completed with exit code 1.
code-quality: packages/ui/modal/src/modal.tsx#L72
React Hook useCallback has a missing dependency: 'onCloseModal'. Either include it or remove the dependency array. If 'onCloseModal' changes too often, find the parent component that defines it and wrap that definition in useCallback
code-quality: packages/ui/uploader/src/uploader-file.tsx#L33
React Hook useEffect has a missing dependency: 'file'. Either include it or remove the dependency array. If 'setPreviewUrl' needs the current value of 'file', you can also switch to useReducer instead of useState and read 'file' in the reducer