Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(icon): Set correct markup. #500

Merged
merged 2 commits into from
May 20, 2022
Merged

docs(icon): Set correct markup. #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebb4a72
📝 docs(showcase): Set correct icon markup.
creador-dev May 20, 2022
c8ff071
📝 docs(showcase): Set correct icon markup.
creador-dev May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _layouts/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@

<div id="button-example-plugin" class="sui-tooltip" data-tooltip="Example Plugin">
<a href="https://bitbucket.org/incsub/shared-ui-example-plugin" target="_blank" class="sui-button-icon sui-button-outlined sui-button-lg">
<i class="sui-icon-plugin-2" aria-hidden="true"></i>
<span class="sui-icon-plugin-2" aria-hidden="true"></span>
<span class="sui-screen-reader-text">Click to open example plugin on a new tab.</span>
</a>
</div>

<div id="button-github-repository" class="sui-tooltip" data-tooltip="Github Repository">
<a href="https://github.com/wpmudev/shared-ui" target="_blank" class="sui-button-icon sui-button-outlined sui-button-lg">
<i class="sui-icon-social-github" aria-hidden="true"></i>
<span class="sui-icon-social-github" aria-hidden="true"></span>
<span class="sui-screen-reader-text">Click to open Github Repository on a new tab.</span>
</a>
</div>
Expand Down
4 changes: 2 additions & 2 deletions assets/js/shared-ui/multistrings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,10 @@

html += '<li title="' + itemName + '">';

html += '<i class="sui-icon-page sui-sm" aria-hidden="true"></i>';
html += '<span class="sui-icon-page sui-sm" aria-hidden="true"></span>';
html += itemName;
html += '<button class="sui-button-close">';
html += '<i class="sui-icon-close" aria-hidden="true"></i>';
html += '<span class="sui-icon-close" aria-hidden="true"></span>';
html += '<span class="sui-screen-reader-text">Delete</span>';
html += '</button>';

Expand Down
2 changes: 1 addition & 1 deletion assets/js/shared-ui/notifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@

innerHTML += '<button class="sui-button-icon">';

innerHTML += '<i class="sui-icon-check" aria-hidden="true"></i>';
innerHTML += '<span class="sui-icon-check" aria-hidden="true"></span>';

if ( '' !== dismiss.label ) {
innerHTML += '<span class="sui-screen-reader-text">' + dismiss.label + '</span>';
Expand Down
4 changes: 2 additions & 2 deletions assets/js/showcase/pages/icons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
'<div class="sui-with-button sui-with-button-icon">' +
'<input type="text" value="&lt;span class=&quot;sui-icon-' + iconName + '&quot; aria-hidden=&quot;true&quot;&gt;&lt;/span&gt;" class="sui-form-control" readonly="readonly" />' +
'<button role="button" class="sui-button-icon icon-item-code--html" data-clipboard-text="&lt;span class=&quot;sui-icon-' + iconName + '&quot; aria-hidden=&quot;true&quot;&gt;&lt;/span&gt;">' +
'<i aria-hidden="true" class="sui-icon-copy"></i>' +
'<span aria-hidden="true" class="sui-icon-copy"></span>' +
'<span class="sui-screen-reader-text">Copy HTML code</span>' +
'</button>' +
'</div>' +
Expand All @@ -122,7 +122,7 @@
'<div class="sui-with-button sui-with-button-icon">' +
'<input type="text" value="@include icon(before, ' + iconName + ', true);" class="sui-form-control" readonly="readonly" />' +
'<button role="button" class="sui-button-icon icon-item-code--scss" data-clipboard-text="@include icon(before, ' + iconName + ', true);">' +
'<i aria-hidden="true" class="sui-icon-copy"></i>' +
'<span aria-hidden="true" class="sui-icon-copy"></span>' +
'<span class="sui-screen-reader-text">Copy HTML code</span>' +
'</button>' +
'</div>' +
Expand Down
18 changes: 9 additions & 9 deletions page-icon-buttons.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,8 +832,8 @@ <h2 class="sui-box-title">Colorize Buttons</h2>
<span class="sui-settings-label" style="margin-bottom: 10px;">Default</span>

<button role="button" class="sui-button-icon sui-button-white">
<i class="sui-icon-close" aria-hidden="true"></i>
<i class="sui-screen-reader-text">Icon Button</i>
<span class="sui-icon-close" aria-hidden="true"></span>
<span class="sui-screen-reader-text">Icon Button</span>
</button>

<div class="demo-code-block" style="margin-top: 10px;">
Expand All @@ -855,8 +855,8 @@ <h2 class="sui-box-title">Colorize Buttons</h2>
<span class="sui-settings-label" style="margin-bottom: 10px;">Outlined</span>

<button role="button" class="sui-button-icon sui-button-white sui-button-outlined">
<i class="sui-icon-close" aria-hidden="true"></i>
<i class="sui-screen-reader-text">Icon Button</i>
<span class="sui-icon-close" aria-hidden="true"></span>
<span class="sui-screen-reader-text">Icon Button</span>
</button>

<div class="demo-code-block" style="margin-top: 10px;">
Expand All @@ -878,8 +878,8 @@ <h2 class="sui-box-title">Colorize Buttons</h2>
<span class="sui-settings-label" style="margin-bottom: 10px;">Large</span>

<button role="button" class="sui-button-icon sui-button-white sui-button-lg">
<i class="sui-icon-close" aria-hidden="true"></i>
<i class="sui-screen-reader-text">Icon Button</i>
<span class="sui-icon-close" aria-hidden="true"></span>
<span class="sui-screen-reader-text">Icon Button</span>
</button>

<div class="demo-code-block" style="margin-top: 10px;">
Expand All @@ -901,7 +901,7 @@ <h2 class="sui-box-title">Colorize Buttons</h2>
<span class="sui-settings-label" style="margin-bottom: 10px;">Disabled</span>

<button role="button" class="sui-button-icon sui-button-white" disabled>
<i class="sui-icon-close" aria-hidden="true"></i>
<span class="sui-icon-close" aria-hidden="true"></span>
<span class="sui-screen-reader-text">Icon Button</span>
</button>

Expand Down Expand Up @@ -951,7 +951,7 @@ <h2 class="sui-box-title">Loading Button</h2>

<button type="button" class="sui-button-icon">
<span class="sui-loading-text" aria-hidden="true">
<span class="sui-icon-academy"></span>
<span class="sui-icon-academy" aria-hidden="true"></span>
</span>
<span class="sui-icon-loader sui-loading" aria-hidden="true"></span>
<span class="sui-screen-reader-text">Icon Button</span>
Expand Down Expand Up @@ -984,7 +984,7 @@ <h2 class="sui-box-title">Loading Button</h2>

<button type="button" class="sui-button-icon sui-button-onload">
<span class="sui-loading-text" aria-hidden="true">
<span class="sui-icon-academy"></span>
<span class="sui-icon-academy" aria-hidden="true"></span>
</span>
<span class="sui-icon-loader sui-loading" aria-hidden="true"></span>
<span class="sui-screen-reader-text">Icon Button</span>
Expand Down
8 changes: 4 additions & 4 deletions page-select.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ <h2 class="sui-box-title">Examples</h2>
type="button"
class="sui-button-icon sui-tabs-navigation--left"
>
<i class="sui-icon-chevron-left"></i>
<span class="sui-icon-chevron-left" aria-hidden="true"></span>
</button>
<button
type="button"
class="sui-button-icon sui-tabs-navigation--right"
>
<i class="sui-icon-chevron-right"></i>
<span class="sui-icon-chevron-right" aria-hidden="true"></span>
</button>
</div>

Expand Down Expand Up @@ -559,13 +559,13 @@ <h2 class="sui-box-title">Usage</h2>
type="button"
class="sui-button-icon sui-tabs-navigation--left"
>
<i class="sui-icon-chevron-left"></i>
<span class="sui-icon-chevron-left" aria-hidden="true"></span>
</button>
<button
type="button"
class="sui-button-icon sui-tabs-navigation--right"
>
<i class="sui-icon-chevron-right"></i>
<span class="sui-icon-chevron-right" aria-hidden="true"></span>
</button>
</div>

Expand Down