Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria(icon-button): Loading state needs to notify the user action is performing. #429

Merged
merged 1 commit into from
Jul 25, 2022
Merged

aria(icon-button): Loading state needs to notify the user action is performing. #429

merged 1 commit into from
Jul 25, 2022

Conversation

creador-dev
Copy link
Member

No description provided.

@creador-dev creador-dev added the improvement Improvements for current features label Dec 29, 2021
@creador-dev creador-dev changed the title 🐛 fix(icon buttons): changed button text to Loading... and added role and aria-live ✨ enhancement(icon buttons): changed button text to Loading... and added role and aria-live Dec 29, 2021
@creador-dev creador-dev changed the title ✨ enhancement(icon buttons): changed button text to Loading... and added role and aria-live ✨ enhancement(icon-buttons): changed button text to Loading... and added role and aria-live Jan 17, 2022
@creador-dev creador-dev added accessibility Improvements related to accessibility and removed improvement Improvements for current features labels Jan 17, 2022
@creador-dev creador-dev changed the base branch from development to version/2.12.11 July 13, 2022 10:37
@iamleigh iamleigh changed the title ✨ enhancement(icon-buttons): changed button text to Loading... and added role and aria-live fix(icon-button): Loading state needs to notify the user action is performing. Jul 25, 2022
@iamleigh iamleigh changed the title fix(icon-button): Loading state needs to notify the user action is performing. aria(icon-button): Loading state needs to notify the user action is performing. Jul 25, 2022
@iamleigh iamleigh merged commit e3d01b3 into version/2.12.11 Jul 25, 2022
@iamleigh iamleigh deleted the fix/SUI-15 branch July 25, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamleigh iamleigh iamleigh approved these changes

Assignees

@creador-dev creador-dev

Labels
accessibility Improvements related to accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@creador-dev @iamleigh