fix(upload-file): Function must run only when a specific class or attribute is added. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamleigh
approved these changes
Nov 2, 2021
iamleigh
changed the title
iamleigh
suggested changes
Nov 2, 2021
There was a problem hiding this comment.
@creador-dev please, use another class name or an attribute instead because we already have sui-upload-file and the one you're using here might get confused the developers since you only switch places the file and upload words.
iamleigh
changed the title
iamleigh
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
SUI_BODY_CLASSand definedif($( 'SUI_BODY_CLASS .sui-file-upload' ).length)to check whether element present in DOM or not.