fix og:url for "dirhtml" builder #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test case for this? |
The "dirhtml" builder correctly uses ".html" as file suffix, but the file suffix should not be part of the URL. We want ".../file_name/" as URL in this case, not ".../file_name.html". Signed-off-by: Ruth Fuchss <[email protected]>
ru-fu
force-pushed
the
fix-url-for-dirhtml
branch
2 times, most recently
from
6ae0dd1 to
608fa23
Compare
Done. |
|
Make sure you run black so tests pass ( |
Signed-off-by: Ruth Fuchss <[email protected]>
ru-fu
force-pushed
the
fix-url-for-dirhtml
branch
from
608fa23 to
a4ac184
Compare
Daltz333
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "dirhtml" builder correctly uses ".html" as file suffix,
but the file suffix should not be part of the URL.
We want ".../file_name/" as URL in this case, not
".../file_name.html".
Signed-off-by: Ruth Fuchss [email protected]