Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert relative paths to absolute in og:image. #48

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

Robpol86
Copy link
Contributor

Always using absolute/full URLs for og:image as long as
config["ogp_site_url"] is set.

Fixes #43

@Daltz333 Daltz333 requested a review from TheTripleV November 16, 2021 00:09
Always using absolute/full URLs for og:image as long as
`config["ogp_site_url"]` is set.

Fixes wpilibsuite#43
@Daltz333 Daltz333 force-pushed the image_absolute_paths_pr branch from 6980a48 to 44372d4 Compare November 20, 2021 03:57
@Daltz333
Copy link
Member

Thank you for your contributions!

@Daltz333
Copy link
Member

Close #43

@Daltz333 Daltz333 merged commit 54ea5eb into wpilibsuite:main Nov 20, 2021
@Robpol86 Robpol86 deleted the image_absolute_paths_pr branch November 20, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use absolute paths for og:image
2 participants