-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npx for calling JS apps #1906
Conversation
|
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
@ChrisWiegman I took a look at this. It looks like it's related to this issue: However I think the solution is simpler. We just have to run Here is the workflow that I used:
We probably need to just update the DEVELOPMENT.md file to include this step. |
After chatting with @theodesp on this, I'm going to close it and re-open with a documentation approach. |
Tasks
Description
With our mono repo we're hitting numerous issues in calling scripts such as the faust cli in various workspaces when work on the project itself (see https://github.com/wpengine/faustjs/actions/runs/9404217613/job/25902618771 for an example). This causes lost time and frustration and it isn't necessary.
To combat this, this PR replaces direct calls to apps such as
faust
,next
and more by using npx to call the apps. This ensures they can be found in the mono repo, changes nothing for existing scripts that already work and reduces setup time and confusion when cloning the repo fresh or working with various packages such as the examples.Testing
Testing can be accomplished with existing CI tools