Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create only necessary backstop reference during related test. #138

Closed
jeawhanlee opened this issue Sep 11, 2024 · 1 comment · Fixed by #141
Closed

Create only necessary backstop reference during related test. #138

jeawhanlee opened this issue Sep 11, 2024 · 1 comment · Fixed by #141
Assignees
Labels
enhancement New feature or request

Comments

@jeawhanlee
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Right now, when we need to do VR testing we create references from the SCENARIO_URLS in wp.config irrespective of the test being run.

Describe the solution you'd like
It would make sense to conditionally create reference based on the current test being run, that way test run faster, less flaky on a poor internet connection with puppeteer trying to visit tons of urls and create reference and also we actually consume resource for only what we need.

I suggest we create a json or array file to hold various scenario urls related to their tests with their key as the script name e.g test:llcssbg this way we can get this script at run time and load it in SCENARIO_URLS in wp.config.ts just in time for backstop to create the references.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jeawhanlee
Copy link
Contributor Author

The suggestion in the issue should suffice for the grooming from my POV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants