Closes #937 Optimise sql query for image counting and statistics

[Khadreal]

Description

Optimise SQL query for image counting.

Fixes #937

Type of change

• Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Check #937

Technical description

Documentation

Modify existing query to be faster and rewrite imagify_has_attachments_without_required_metadata sql to be more optimised.
Changed from using left join to Exists

Mandatory Checklist

Code validation

• I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Code style

• I wrote a self-explanatory code about what it does.
• I protected entry points against unexpected inputs.
• I did not introduce unnecessary complexity.
• Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

If some mandatory items are not relevant, explain why in this section.

Additional Checks

• In the case of complex code, I wrote comments to explain it.
• When possible, I prepared ways to observe the implemented system (logs, data, etc.).
• I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 2ec0c9f1	❌ 0.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (2ec0c9f)	Report Missing	Report Missing	Report Missing
Head commit (9d1f8d3)	13373	29	0.22%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#957)	75	0	0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[MathieuLamiot]

@Khadreal Do you think adding tests could be beneficial on those queries?
It could help ensure we have the same results before and after the changes.

[Khadreal]

@Khadreal Do you think adding tests could be beneficial on those queries?
It could help ensure we have the same results before and after the changes.

Yes, Will try to add a test to it.

[Mai-Saad]

@Khadreal Thanks for the PR. here is a test sample result of PR Vs Production
1- improvement in this query imagify_has_attachments_without_required_metadata()
2- increase in this query imagify_count_optimized_attachments()
3- some queries added on PR with certain actions and not there on production (the grey cells)

What do you think?

[Khadreal]

@Mai-Saad will fine tune the queries that increased, the queries that are added on the PR and not on production could be as a result of filter here which is disable by default. Are you certain that the filter is not enable during your test ?

[Mai-Saad]

The filter imagify_display_library_stats is enabled on both production and PR
https://bmdo-my.sharepoint.com/:x:/r/personal/mai_saad_group_one/Documents/imagify%20measurements.xlsx?d=w83baa867dabe49c1abbae2280ab91751&csf=1&web=1&e=4nNfQX

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 2ec0c9f1	❌ 5.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (2ec0c9f)	Report Missing	Report Missing	Report Missing
Head commit (4485594)	13954	48	0.34%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#957)	100	5	5.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[Mai-Saad]

=> Quries mentioned https://bmdo-my.sharepoint.com/:x:/r/personal/mai_saad_group_one/_layouts/15/Doc.aspx?sourcedoc=%7B83BAA867-DABE-49C1-ABBA-E2280AB91751%7D&file=imagify%20measurements.xlsx&action=default&mobileredirect=true&DefaultItemOpen=1&ct=1737700216466&wdOrigin=OFFICECOM-WEB.MAIN.REC&cid=f7eeb5e6-4928-408d-854f-1bf7870c551e&wdPreviousSessionSrc=HarmonyWeb&wdPreviousSession=50d0eacb-affe-42bc-b8cd-32bb662a4e01 are better now (some values are slightly bigger on PR but measurements can vary each time doing same steps)
=> NRT plan https://wpmediaqa.testrail.io/index.php?/runs/view/954&group_by=cases:section_id&group_order=asc

[Mai-Saad]

Working as expected.
Note:

• some test cases need maintenance
• already on trunk, if we deleted imagify_user_cache transient, it will be recreated and API request will be sent while being on transient page , refreshing won't send any requests
  testrail-report-685.pdf