fix: page link field type #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonbahl
added
the
compat: possible break
- update PageLinkFieldTest to test against pretty permalinks
3 tasks
|
Any update when this will be fixed @jasonbahl ? I'm running into this issue now, workaround for me is a text field and getting users to enter a slug, not ideal but works for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This updates the "Page Link" field type to map to the GraphQL Schema as a List of Strings by default instead of a Connection.
Does this close any currently open issues?
closes #213
Any other comments?
As-is this would be a breaking change. I need to figure out if we can do this in a non-breaking way, which would mean leaving the field type mapping to the Schema as a Connection but allowing users to opt-in to the field type resolving differently (String, list of String, etc)