Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make-php: skip strings without translation #389

Merged
merged 1 commit into from
Feb 28, 2024
Merged

make-php: skip strings without translation #389

merged 1 commit into from
Feb 28, 2024

Conversation

swissspidy
Copy link
Member

Without this, a string without a translation would have an empty string as a translation, which would cause WP to show that empty string instead of the original.

Props @lgladdy

@swissspidy swissspidy added this to the 2.6.1 milestone Feb 28, 2024
@swissspidy swissspidy requested a review from a team as a code owner February 28, 2024 10:51
@lgladdy
Copy link

lgladdy commented Feb 28, 2024 •
edited
Loading

This fix is working for me.

Blank strings in .po files no longer get output to the l10n.php files solving the issue of blank output for those strings in WordPress.

@swissspidy swissspidy merged commit 7538d68 into main Feb 28, 2024
65 checks passed
@swissspidy swissspidy deleted the fix/make-php-skip-empty branch February 28, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
bug command:i18n-make-php
Projects
None yet
Milestone
2.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@swissspidy @lgladdy @danielbachhuber