Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix JSON files with text domain if needed #313

Merged
merged 7 commits into from
Jul 4, 2022
Merged

Conversation

swissspidy
Copy link
Member

Fixes #197

@swissspidy swissspidy added this to the 2.4.0 milestone Apr 30, 2022
@swissspidy swissspidy requested a review from a team as a code owner April 30, 2022 11:02
src/MakeJsonCommand.php Outdated Show resolved Hide resolved
src/MakeJsonCommand.php Outdated Show resolved Hide resolved
@swissspidy swissspidy requested a review from schlessera July 4, 2022 15:58
src/MakeJsonCommand.php Outdated Show resolved Hide resolved
Co-authored-by: Alain Schlesser <[email protected]>
@schlessera schlessera merged commit 45bc2b4 into main Jul 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/197-theme-domain branch July 4, 2022 21:43
@drzraf
Copy link

drzraf commented Oct 30, 2024

I'm retrieving my PO files from Weblate using wlc: these are missing a proper Domain header and still, I'd expect make-json to be able to deal with that (eg with a --domain flag).
Not sure what workflow expectations are adequate, but for me, it makes sense to give control over a specific domain setting at the make-json step.

@swissspidy
Copy link
Member Author

@drzraf Please open a new issue for your enhancement request instead of commenting on an old merged PR. Thanks!

I also suggest reaching out to your PO file provider to include the Domain header, as it‘s generally a good practice.

@drzraf drzraf mentioned this pull request Nov 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make-json: generated file missing theme textdomain prefix
3 participants