Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort translation files by name to ensure same order on all systems #173

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Sort translation files by name to ensure same order on all systems #173

merged 1 commit into from
Jul 23, 2019

Conversation

l3ku
Copy link
Contributor

@l3ku l3ku commented Jul 19, 2019

See #171 for a better explanation on why to sort the translation files.

@l3ku l3ku requested a review from a team as a code owner July 19, 2019 06:47
@swissspidy
Copy link
Member

Would you mind adding some tests demonstrating that this works? :-)

@l3ku
Copy link
Contributor Author

l3ku commented Jul 19, 2019

I have now included a test case into /tests/IterableCodeExtractorTest.php. I did not add any new test data files into /tests/data, do you think that validating that all of the already existing files are returned in the intended order is sufficient or should I make the test more extensive?

@swissspidy swissspidy requested a review from a team July 23, 2019 07:48
@schlessera schlessera added this to the 2.2.0 milestone Jul 23, 2019
@schlessera schlessera merged commit 4ab93fd into wp-cli:master Jul 23, 2019
@ottok ottok mentioned this pull request Nov 29, 2019
Merged
schlessera added a commit that referenced this pull request Jan 6, 2022
@schlessera
Merge pull request #173 from l3ku/master
4f49fe1 
Sort translation files by name to ensure same order on all systems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
bug command:i18n
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@l3ku @swissspidy @schlessera