Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in gettext 4.8.5 #269

Closed
theimbender opened this issue Jul 17, 2021 · 1 comment
Closed

Breaking change in gettext 4.8.5 #269

theimbender opened this issue Jul 17, 2021 · 1 comment

Comments

@theimbender
Copy link

In v4.8.5 of gettext, this change was made to cache redundant translator comments, but this breaks MakePotCommand.php because $comment can now be an object and not a string, if a translators: comment is found.

Not sure if the maintainers of this project wanted to reach out to gettext in case this should be backed out in their patch releases, or if the logic here should be changed, or if you'd want to just set 4.8.4 instead of ^4.8 in i18n's composer.json

theimbender added a commit to theimbender/i18n-command that referenced this issue Jul 17, 2021
@swissspidy
Copy link
Member

Thanks for opening this. As I am the one who added this change I realized the issue as well the other day. Will look into the different options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants