-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Warning for make-pot command: Empty needle for strpos() #125
Comments
Never ran into this, but it should be an easy fix. Code in question: i18n-command/src/IterableCodeExtractor.php Lines 171 to 180 in 0723170
Seems like the following command was run on Travis:
@westonruter Out of curiosity, why does the plugin still use make-pot and pot-to-php? Just for WP 4.9 + Gutenberg compatibility? Because with WordPress 5.0 it shouldn't be needed anymore. |
@swissspidy Good question. The plugin is using |
I've noticed a PHP warning being raised when running the
make-pot
command:You can see this from a Travis build of the AMP plugin as well: https://travis-ci.org/ampproject/amp-wp/jobs/467674548#L355-L380
The text was updated successfully, but these errors were encountered: