Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA workflow validation #79

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

schlessera
Copy link
Member

Use the Action Validator to do some initial smoke testing of the GitHub Actions workflows.

@schlessera schlessera requested a review from a team as a code owner October 27, 2023 09:42
@schlessera schlessera added enhancement New feature or request scope:testing and removed enhancement New feature or request labels Oct 27, 2023
@swissspidy
Copy link
Member

Shouldn't I be seeing this job now in the successful checks list? 🤔

Given that all the commands just use the reusable workflows from this repo, there doesn't seem to be too much value in running this for all of them, but I guess it can't hurt. Seems more important to ensure the reusable workflows match the schema.

@schlessera
Copy link
Member Author

schlessera commented Oct 27, 2023

This will not show up just yet as the action pulls the reusable workflows from the main branch. Once we merge this, the change will be part of the main branch and appear in all subsequent runs.

I thought it might make sense to include for all repos to make sure PRs don't mess up the testing.yml file that is meant to pull in the reusable one. Not sure how much value this provides, but the more checks the merrier, I guess?

@swissspidy swissspidy merged commit fdabbae into main Oct 27, 2023
@swissspidy swissspidy deleted the add/gha-workflow-validation branch October 27, 2023 10:50
@swissspidy
Copy link
Member

@schlessera So that didn't quite work 🤔

https://github.com/wp-cli/.github/actions/runs/6666231157/job/18117347330

Weird that it says it's not installed after just installing it 🤷


Aside:

I already had the tool installed via npm, but I just realized there it doesn't have a --verbose option 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants