Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Martinh/ntt config update #160

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Martinh/ntt config update #160

merged 6 commits into from
Dec 6, 2024

Conversation

martin0995
Copy link
Collaborator

Description

Add details to the NTT configuration pages.

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@martin0995 martin0995 added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Dec 4, 2024
evgeniko
evgeniko previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@evgeniko evgeniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

eshaben
eshaben reviewed Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor things 🙂

build/contract-integrations/native-token-transfers/configuration/rate-limiting.md Outdated Show resolved Hide resolved
build/contract-integrations/native-token-transfers/configuration/rate-limiting.md Outdated Show resolved Hide resolved
build/contract-integrations/native-token-transfers/configuration/rate-limiting.md Outdated Show resolved Hide resolved
eshaben
eshaben approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilariae ilariae merged commit 6862950 into main Dec 6, 2024
1 check passed
@ilariae ilariae deleted the martinh/ntt-config-update branch December 6, 2024 15:07
This was referenced Dec 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

@evgeniko evgeniko evgeniko left review comments

Assignees
No one assigned
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martin0995 @eshaben @evgeniko @ilariae