Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerated tables with unichain info #121

Merged
merged 2 commits into from
Oct 18, 2024
Merged

regenerated tables with unichain info #121

merged 2 commits into from
Oct 18, 2024

Conversation

martin0995
Copy link
Collaborator

Description

Manually added Unichain to Core Contracts and Token Bridge tables.

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@martin0995 martin0995 added the A0 - New Content Pull request contains new content pages label Oct 15, 2024
@martin0995 martin0995 requested a review from eshaben October 15, 2024 18:22
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I just don't want to reintroduce MainNet and TestNet. I also noticed we never fixed DevNet, so that should be Devnet.

Additionally, looks like Goerli is still in these tables. I made a comment about this in the mkdocs PR. It doesn't need to be fixed here, but I would have assumed that based on the other PR that it would have been

.snippets/text/build/reference/chain-ids/chain-ids.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🚢

@eshaben eshaben merged commit 3a676cd into main Oct 18, 2024
1 check passed
@eshaben eshaben deleted the martinh/unichain branch October 18, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants