-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: The sol icon is replaced with base64 #3106
fix: The sol icon is replaced with base64 #3106
Conversation
👷 Deploy request for wormhole-connect pending review.Visit the deploys page to approve it
|
👷 Deploy request for wormhole-connect-mainnet pending review.Visit the deploys page to approve it
|
Hey @friendlysxw , thanks for the PR! I looked into this and not 100% sure if the icon problem is due to multiple Solana svgs having same id Do you get any warnings/errors in the browser console regarding this? Which browser version are you using? |
No errors and related alerts in the console. Chrome/131.0.0.0 |
Oh, yes. The possible issue is that there is an element with the same id in my project but with a different style. However, in my project, I couldn't find any elements other than this SOL icon using The only way I can currently solve this problem is to replace the SVGs with id attributes in this repository with other image formats, or to ensure that the ids in the SVGs are unique. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR, but we want to stay on SVG for all our icons. is there another solution that keeps it as an SVG?
closing this pr to keep the queue clean. @friendlysxw please let us know if you have updates and we can reopen it. |
In the SVG of sol, there is an id, and this SVG will render multiple times in the document flow, causing the id to repeat. Once the id is duplicated, the SVG will not render properly. To solve this problem, you can consider using PNG images or converting the SVG to base64 images.
After the modification: