Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Fix the relay fee amount in Solana NTT #472

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

barnjamin
Copy link
Contributor

The fee returned from quoteDeliveryPrice is in lamports but the createRequestRelayInstruction expects it to be in Sol

Copy link
Collaborator

@nvsriram nvsriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@barnjamin barnjamin requested a review from artursapek July 9, 2024 17:38
@barnjamin barnjamin merged commit 9f9dd3f into main Jul 9, 2024
7 checks passed
@barnjamin barnjamin deleted the sdk/fix-fee-amount branch July 9, 2024 18:04
bruce-riley pushed a commit to wormholelabs-xyz/native-token-transfers that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants