Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of changing equations #18

Closed
paulobruno opened this issue Sep 12, 2022 · 5 comments
Closed

Add example of changing equations #18

paulobruno opened this issue Sep 12, 2022 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@paulobruno
Copy link
Collaborator

It is possible to do this without changing the package code, but it's not trivial. Currently, we have to look for the equation we want to change in the vector of system equations manually.

@natema natema added the documentation Improvements or additions to documentation label Sep 12, 2022
@natema natema added this to the first release milestone Sep 12, 2022
@natema
Copy link
Member

natema commented Sep 12, 2022

I think this is fair enough atm. Also, after a first example where we change an equation of the whole system, we can have another example where we change an equation of a subsystem. From that point of view, equations are already grouped in subsystems, so looking for them shouldn't be terrible.

paulobruno added a commit that referenced this issue Sep 12, 2022
Related to Issue #18
@paulobruno
Copy link
Collaborator Author

paulobruno commented Sep 12, 2022

I added an example in the Agriculture fig. 4.87.
It is possible to do, but I am not yet comfortable in having to look the number of the equation before changing it.

@universmile
Copy link
Contributor

At the moment, one has to print the array of equations and look at its index, which seems cumbersome. We should find some remedy before implementing the remaining 11 figures that require editing equations, then have it documented.

@natema
Copy link
Member

natema commented Sep 21, 2022

I don't see a natural way to address this point.
Can be an enhancement for a future version, but atm unless you have a proposal, I'll let it as is.

@paulobruno
Copy link
Collaborator Author

Since we have a way to do so, which was the goal of the issue, i'm closing it.
I'll open a new one to improve the current process of changing equations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants