Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Call noise correction python binary from kotlin. #1803

Merged
merged 30 commits into from
Oct 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4b6d369
Call python binary from kotlin.
ple13 Sep 12, 2024
170778c
Merge branch 'main' into lephi-noise-correction-works-with-report-proto
ple13 Sep 12, 2024
0f56f0b
Fix Lint.
ple13 Sep 12, 2024
cb74ffa
Fix Lint.
ple13 Sep 12, 2024
0fa5b25
Fix Lint.
ple13 Sep 12, 2024
f45692b
Address comments.
ple13 Sep 16, 2024
178b19a
Clean up.
ple13 Sep 16, 2024
875164c
Fix Lint.
ple13 Sep 16, 2024
b073960
The noise correction tool uses report in json format as input.
ple13 Oct 1, 2024
bdc12e8
Fix Lint.
ple13 Oct 1, 2024
e2cf97d
Fix Lint.
ple13 Oct 1, 2024
6c5613e
Support multiple filter groups.
ple13 Oct 2, 2024
ed8654e
Fix Lint.
ple13 Oct 2, 2024
a7f6dff
Address comments.
ple13 Oct 3, 2024
2f3aca6
Fix lint.
ple13 Oct 4, 2024
ccb4f51
Merge branch 'main' into lephi-noise-correction-works-with-report-proto
ple13 Oct 4, 2024
e04927a
Address comments.
ple13 Oct 7, 2024
ffa54a0
Fix Lint.
ple13 Oct 7, 2024
202d233
Address comments.
ple13 Oct 8, 2024
400034b
Fix Lint.
ple13 Oct 8, 2024
0315e94
Clean up python import.
ple13 Oct 8, 2024
688d85f
Address comments.
ple13 Oct 9, 2024
79ccd89
Merge branch 'main' into lephi-noise-correction-works-with-report-proto
ple13 Oct 9, 2024
74bca3d
Address comments.
ple13 Oct 10, 2024
363ffda
Fix Lint.
ple13 Oct 10, 2024
282bb21
Address comments.
ple13 Oct 10, 2024
6d04398
Fix Lint.
ple13 Oct 10, 2024
babc055
Add newline at the end of files.
ple13 Oct 10, 2024
535f471
Address comments.
ple13 Oct 10, 2024
fd1fe20
Merge branch 'main' into lephi-noise-correction-works-with-report-proto
ple13 Oct 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Lint.
ple13 committed Sep 16, 2024
commit 875164caa8b5572a0bc1f1fc653a7647e0e5f943
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@ import java.nio.file.Path
import java.util.logging.Logger

/**
*
* This class corrects the noisy measurements of a report.
*
* This depends on the python library correct_origin_report for noise correction.
Original file line number Diff line number Diff line change
@@ -30,7 +30,9 @@ class CorrectOriginReportTest {
val inputPath =
Path.of("experimental/dp_consistency/src/test/kotlin/tools/example_origin_report.xlsx")
val outputPath =
Path.of("experimental/dp_consistency/src/test/kotlin/tools/example_origin_corrected_report.xlsx")
Path.of(
"experimental/dp_consistency/src/test/kotlin/tools/example_origin_corrected_report.xlsx"
)

// Makes sure that the output file does not exist before the execution.
if (Files.exists(outputPath)) {