-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tool library for updating Spanner schema using Liquibase. #109
Conversation
41e0135
to
ded8a3d
Compare
fc201a0
to
c814c4f
Compare
518b338
to
90afdf5
Compare
c814c4f
to
84d0b97
Compare
05c7d84
to
d579bd6
Compare
d579bd6
to
f4eef40
Compare
764dd51
to
cc6bd39
Compare
f4eef40
to
5c3d302
Compare
cc6bd39
to
6889c09
Compare
5c3d302
to
310ae83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas and @stevenwarejones)
src/main/kotlin/org/wfanet/measurement/gcloud/spanner/tools/UpdateSchema.kt
line 47 at r1 (raw file):
val connectionString = if (flags.emulatorHost == null) { "jdbc:cloudspanner:/projects/${flags.projectName}/instances/${flags.instanceName}/" +
Maybe val databasePath = "projects/.../instances/.../databases/..."
so you can reuse it between the two branches here (and also make it more compact).
That could even be a property on SpannerFlags
.
6889c09
to
db6afc1
Compare
310ae83
to
7efaf64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @efoxepstein and @stevenwarejones)
src/main/kotlin/org/wfanet/measurement/gcloud/spanner/tools/UpdateSchema.kt
line 47 at r1 (raw file):
Previously, efoxepstein (Eli Fox-Epstein) wrote…
Maybe
val databasePath = "projects/.../instances/.../databases/..."
so you can reuse it between the two branches here (and also make it more compact).That could even be a property on
SpannerFlags
.
Done, and moved to SpannerFlags
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein)
db6afc1
to
828df35
Compare
7efaf64
to
00d90ea
Compare
828df35
to
fe077e3
Compare
0d27c21
to
dfaff9a
Compare
dfaff9a
to
696bbac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)
https://rally1.rallydev.com/#/?detail=/task/636975105303&fdp=true