feat(gantt): support quick time focus #TINFR-1044 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luxiaobei
reviewed
Nov 26, 2024
packages/gantt/src/root.component.ts
Outdated
| @@ -127,7 +127,7 @@ export class NgxGanttRootComponent implements OnInit, OnDestroy { | |||
| } | |||
|
|
|||
| private setupViewScroll() { | |||
| if (this.ganttUpper.disabledLoadOnScroll) { | |||
| if (this.ganttUpper.disabledLoadOnScroll || this.dom.isViewScrollSet) { | |||
There was a problem hiding this comment.
if (this.ganttUpper.disabledLoadOnScroll && !this.ganttUpper.quickTimeFocus)
| ) {} | ||
|
|
||
| ngOnInit(): void { | ||
| const onStable$ = this.ngZone.isStable ? from(Promise.resolve()) : this.ngZone.onStable.pipe(take(1)); |
There was a problem hiding this comment.
这些是不是可以去掉？是为了解决初始的时候，visibleRangeX没有值?
There was a problem hiding this comment.
最新的提交没有去掉，是为了稳定后获取到 mainContainer。对 mainContainer 的位置变化进行监听
luxiaobei
approved these changes
Nov 27, 2024
| @Output() barClick = new EventEmitter<GanttBarClickEvent>(); | ||
|
|
||
| @Output() lineClick = new EventEmitter<GanttLineClickEvent>(); | ||
|
|
||
| @HostBinding('class.gantt-main-container') ganttMainClass = true; | ||
|
|
||
| constructor(@Inject(GANTT_UPPER_TOKEN) public ganttUpper: GanttUpper) {} | ||
| private unsubscribe$ = new Subject<void>(); |
There was a problem hiding this comment.
最好使用新的特性 takeUntilDestroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.