fix: NEXT_PUBLIC variable access

[ijxy]

Ensure that the NEXT_PUBLIC_ variable is inlined during builds.

https://nextjs.org/docs/app/building-your-application/configuring/environment-variables#bundling-environment-variables-for-the-browser

(The above link specifically talks about the browser, but the inlining of NEXT_PUBLIC variables also applies to middleware).

[ijxy]

@PaulAsjes I tried out the new version and ran into an issue with the variable still being undefined.

const getEnv = (name: string) => process.env[name];

export function middleware(_request: NextRequest, _event: NextFetchEvent) {
  console.log({
    NEXT_PUBLIC_WORKOS_REDIRECT_URI: process.env.NEXT_PUBLIC_WORKOS_REDIRECT_URI,
    NEXT_PUBLIC_WORKOS_REDIRECT_URI_2: getEnv("NEXT_PUBLIC_WORKOS_REDIRECT_URI"),
  });
}

leads to

{
  NEXT_PUBLIC_WORKOS_REDIRECT_URI: 'https://***-hrs2cwz03-***.vercel.app/api/auth/callback',
  NEXT_PUBLIC_WORKOS_REDIRECT_URI_2: undefined
}

[PaulAsjes]

This is baffling, I wonder why process.env[name] isn't working as expected. Since getEnvVariable doesn't add much anymore, would you mind replacing every instance in this file with a direct lookup of process.env? e.g.

Suggested change

	const WORKOS_REDIRECT_URI = process.env.NEXT_PUBLIC_WORKOS_REDIRECT_URI ?? '';
	const WORKOS_API_HOSTNAME = process.env..WORKOS_API_HOSTNAME;
	const WORKOS_API_HTTPS = process.env.WORKOS_API_HTTPS;
	const WORKOS_API_KEY = process.env.WORKOS_API_KEY ?? '';
	const WORKOS_API_PORT = process.env.WORKOS_API_PORT;
	const WORKOS_CLIENT_ID = process.env.WORKOS_CLIENT_ID ?? '';
	const WORKOS_COOKIE_DOMAIN = process.env.WORKOS_COOKIE_DOMAIN;
	const WORKOS_COOKIE_MAX_AGE = process.env.WORKOS_COOKIE_MAX_AGE;
	const WORKOS_COOKIE_NAME = process.env.WORKOS_COOKIE_NAME;
	const WORKOS_COOKIE_PASSWORD = process.env.WORKOS_COOKIE_PASSWORD ?? '';
	const WORKOS_REDIRECT_URI = process.env.NEXT_PUBLIC_WORKOS_REDIRECT_URI ?? '';

[PaulAsjes]

Didn't see the nextjs docs you linked, makes sense now. Thanks for catching!