Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for organizationId parameter when signing in or refreshing session #73

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

mthadley
Copy link
Contributor

@mthadley mthadley commented Aug 2, 2024

Makes the following changes to the public interface:

  • Adds a new organizationId parameter to getSignInUrl
  • Adds a new refreshSession helper function that also accepts an organizationId parameter`

Internally, it the middleware is updated to pass the current org_id from the access_token when automatically refreshing sessions, in order to preserve the currently authorized organization.

@mthadley mthadley requested a review from cmatheson August 2, 2024 22:28
Copy link

linear bot commented Aug 2, 2024

Copy link
Collaborator

@PaulAsjes PaulAsjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some instructions to the readme on how and when to use refreshSession?

package.json Outdated
@@ -21,7 +21,7 @@
"test": "echo \"Error: no test specified\" && exit 1"
},
"dependencies": {
"@workos-inc/node": "7.14.0",
"@workos-inc/node": "7.18.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: we're on 7.20.0 as of today.

Copy link
Collaborator

@PaulAsjes PaulAsjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny wordsmithing nit, otherwise good!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Paul Asjes <[email protected]>
@mthadley mthadley merged commit 2e0b129 into main Aug 6, 2024
@mthadley mthadley deleted the feature/auth-3342-update-authkit-next-sdk branch August 6, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants