Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds configurable baseURL in the auth redirect route #130

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Adds configurable baseURL in the auth redirect route #130

merged 2 commits into from
Nov 11, 2024

Conversation

PaulAsjes
Copy link
Collaborator

Fixes #37

Adds a new baseURL configuration option to handleAuth. This is to circumvent scenarios where request.nextUrl points to an internal URL rather than the intended one.

@PaulAsjes PaulAsjes mentioned this pull request Nov 6, 2024
Closed
@PaulAsjes PaulAsjes requested a review from mthadley November 7, 2024 10:21
mattgd
mattgd approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@mattgd mattgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me 👍

@PaulAsjes PaulAsjes merged commit 3984301 into main Nov 11, 2024
@PaulAsjes PaulAsjes deleted the pma/configure-redirect-baseurl branch November 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgd mattgd mattgd approved these changes

@mthadley mthadley Awaiting requested review from mthadley

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post login redirect taking me to 0.0.0.0:3000
2 participants
@PaulAsjes @mattgd