Add signUpPaths configuration #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgd
reviewed
Nov 7, 2024
src/session.ts
Outdated
Comment on lines
365
to
372
| if (!Array.isArray(signUpPaths)) { | ||
| return signUpPaths.includes(pathname) ? 'sign-up' : 'sign-in'; | ||
| } | ||
|
|
||
| const screenHintPaths: string[] = signUpPaths.filter((pathGlob) => { | ||
| const pathRegex = getMiddlewareAuthPathRegex(pathGlob); | ||
| return pathRegex.exec(pathname); | ||
| }); |
There was a problem hiding this comment.
Is there a reason we pass the paths through getMiddlewareAuthPathRegex if signUpPaths is an array, but not if it's a single value? Could a single value also be a path glob?
There was a problem hiding this comment.
That's an excellent point!
mattgd
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
Adds
signUpPathsto middleware configuration, which allows you to specify which paths should show the "sign up" screen hint over the default "sign in".