Fix signOut
for custom cookie domains
#116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
signOut
method in auth.ts does not delete cookies set with a custom domain. To reproduce, I had an application withWORKOS_COOKIE_DOMAIN
set (I had it set to.myrootdomain.extension
for local), andsignOut
did end the user session on the WorkOS dashboard, but didn't delete the session cookie, so the user still appeared logged in. This PR letssignOut
delete custom domain cookies by checking if a custom domain has been set for the cookie. If so, it adds the custom domain to the keys thatcookies().delete()
matches against, now finding the cookie and deleting it. I've tested this locally by using this fork of the package in my app.This lets authkit-nextjs work for applications that use a subdomain per customer (ex.
customer1.myenterpriseco.com
).In case this takes a while to merge and other people run into this issue, I'm using a custom sign out method as a workaround: