Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove missing_product_blocks check in diff_product_in_database #89

Merged
merged 4 commits into from
Feb 2, 2022
Merged

Remove missing_product_blocks check in diff_product_in_database #89

merged 4 commits into from
Feb 2, 2022

Conversation

tjeerddie
Copy link
Contributor

@tjeerddie tjeerddie commented Feb 1, 2022 •
edited
Loading

  • Remove node_subscription_id resource type
  • Add find_by_tag in ProductBlockTable model

@tjeerddie tjeerddie force-pushed the change-product-block-relations branch from b9b989b to b0d66c6 Compare February 1, 2022 13:03
pboers1988
pboers1988 approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@pboers1988 pboers1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboers1988 pboers1988 merged commit ff6af88 into main Feb 2, 2022
@pboers1988 pboers1988 deleted the change-product-block-relations branch February 2, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboers1988 pboers1988 pboers1988 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjeerddie @pboers1988