Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tlc #8

Merged
merged 4 commits into from
Apr 6, 2021
Merged

Tlc #8

merged 4 commits into from
Apr 6, 2021

Conversation

hmvp
Copy link
Contributor

@hmvp hmvp commented Apr 6, 2021

Add translations endpoint
Add product sanity checker

- Remove TYPE_CHECKING code
- Improve type checking
@@ -13,7 +13,7 @@

"""This is the orchestrator workflow engine."""

__version__ = "0.0.9"
__version__ = "0.0.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with the other PR

hmvp added 3 commits April 6, 2021 15:13
This adds a translations endpoint that is used to get translations for the workflow specific stuff.
This also adds a task and schedule to do sanity checks on the database
@codecov-io
Copy link

Codecov Report

Merging #8 (09c640a) into main (f43f25a) will decrease coverage by 0.28%.
The diff coverage is 70.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   81.43%   81.14%   -0.29%     
==========================================
  Files          81       86       +5     
  Lines        4502     4667     +165     
  Branches      535      569      +34     
==========================================
+ Hits         3666     3787     +121     
- Misses        695      726      +31     
- Partials      141      154      +13     
Impacted Files Coverage Δ
orchestrator/workflows/tasks/validate_products.py 64.34% <64.34%> (ø)
orchestrator/schedules/validate_products.py 71.42% <71.42%> (ø)
orchestrator/services/translations.py 71.42% <71.42%> (ø)
...1-04-06_3c8b9185c221_add_validate_products_task.py 81.25% <81.25%> (ø)
orchestrator/api/api_v1/endpoints/translations.py 81.81% <81.81%> (ø)
orchestrator/__init__.py 100.00% <100.00%> (ø)
orchestrator/api/api_v1/api.py 100.00% <100.00%> (ø)
orchestrator/domain/base.py 71.95% <100.00%> (ø)
orchestrator/exception_handlers.py 75.00% <100.00%> (ø)
orchestrator/forms/validators.py 93.24% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f43f25a...09c640a. Read the comment docs.

@pboers1988 pboers1988 merged commit c4b1e87 into main Apr 6, 2021
@pboers1988 pboers1988 deleted the tlc branch April 6, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants