Update websocket all processes #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tjeerddie
commented
Dec 22, 2021
•
tjeerddie
commented
- improve process data in all processes websocket endpoint.
- remove logic to send failed processes as the first websocket message, initial data will come from http request.
- rename create_process_step_websocket_data to create_process_websocket_data.
- rename send_process_data_to_websocket to create_process_websocket_data.
- move logic done within process show endpoint to the show_process function, so it will also be used for the all processes websocket.
- change the create_process_websocket_data to only return process data, the step data is already in the process data.
- remove unnecessary process detail websocket endpoint.
- remove engine settings from channels in send_process_data_to_websocket function, it does not need process data.
- Load new process stat in processes service before creating websocket data.
- remove logic to send failed processes as the first websocket message, initial data will come from http request. - rename create_process_step_websocket_data to create_process_websocket_data. - rename send_process_data_to_websocket to create_process_websocket_data. - move logic done within process show endpoint to the show_process function, so it will also be used for the all processes websocket. - change the create_process_websocket_data to only return process data, the step data is already in the process data.
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 84.51% 84.34% -0.18%
==========================================
Files 84 84
Lines 4793 4759 -34
Branches 804 800 -4
==========================================
- Hits 4051 4014 -37
- Misses 601 609 +8
+ Partials 141 136 -5
Continue to review full report at Codecov.
|
howderek
added a commit
to esnet/orchestrator-core
that referenced
this pull request
Jan 25, 2022
…ator-core into upstream * 'main' of git://github.com/workfloworchestrator/orchestrator-core: (26 commits) Websocket add ping pong and close ws on server shutdown (workfloworchestrator#85) fix for failing namespace based cache cleanup (workfloworchestrator#82) fix for failing namespace based cache cleanup (workfloworchestrator#81) Update core to fixed regression introduced in 0.3.0 Ensure proces endpoint shows product info for subscriptions in processes (workfloworchestrator#80) Remove ResourceType ORM (workfloworchestrator#79) Updated orchestrator-core to be compatible with Pydantic 1.9.0 (workfloworchestrator#78) Update from add_set_insync_api (workfloworchestrator#76) Example documents on setting up the Orchestrator Core (workfloworchestrator#25) 0.3.0-rc1 Update websocket all processes (workfloworchestrator#74) Fix engine websocket endpoint (workfloworchestrator#75) Update from 7_implement_websocket_for_engine_settings (workfloworchestrator#70) Pydantic 1.9.0a1 Removing direct dependancies. Add nitpick configuration and add it to pre-commit (workfloworchestrator#68) Update pyproject.toml (workfloworchestrator#71) Fix github unit tests workflow from getting stuck (workfloworchestrator#69) Update from 1255-webserver-hot-reload-broken (workfloworchestrator#67) Update from add-more-docs (workfloworchestrator#66) Fix flake8 issues ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.