Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from websocket-process-list #53

Merged
merged 7 commits into from
Oct 25, 2021
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 15, 2021

  • Send failed processes after connecting to proces list websocket
  • change pytest.mark.skipif to conditional skip inside the tests because the value is not set outside of tests.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #53 (82f6eb9) into main (d4a976f) will increase coverage by 0.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   84.43%   84.91%   +0.47%     
==========================================
  Files          84       84              
  Lines        4723     4726       +3     
  Branches      616      616              
==========================================
+ Hits         3988     4013      +25     
+ Misses        603      581      -22     
  Partials      132      132              
Impacted Files Coverage Δ
orchestrator/api/api_v1/endpoints/processes.py 74.19% <100.00%> (+3.63%) ⬆️
orchestrator/websocket/websocket_manager.py 70.73% <0.00%> (+2.43%) ⬆️
orchestrator/websocket/memory_websocket_manager.py 79.54% <0.00%> (+31.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a976f...82f6eb9. Read the comment docs.

- add test_workflow_2 to have a second workflow (without form step).
@pboers1988 pboers1988 merged commit d351110 into main Oct 25, 2021
@pboers1988 pboers1988 deleted the websocket-process-list branch October 25, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants