Database interaction commands #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4 +/- ##
==========================================
- Coverage 82.03% 81.56% -0.48%
==========================================
Files 80 81 +1
Lines 4437 4496 +59
Branches 534 540 +6
==========================================
+ Hits 3640 3667 +27
- Misses 660 687 +27
- Partials 137 142 +5
Continue to review full report at Codecov.
|
pboers1988
force-pushed
the
database
branch
2 times, most recently
from
3f365ef to
3bdda36
Compare
hmvp
reviewed
Mar 24, 2021
pboers1988
force-pushed
the
database
branch
2 times, most recently
from
dd01c86 to
5a6ea0b
Compare
thijs-creemers
approved these changes
Mar 25, 2021
acidjunk
reviewed
Mar 25, 2021
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| """This is the orchestrator workflow engine.""" | |||
|
|
|||
| __version__ = "0.0.2rc2" | |||
| __version__ = "0.0.2rc11" | |||
There was a problem hiding this comment.
we might start using a scheme here ;)
| @@ -37,5 +37,6 @@ | |||
| NODE_SUBSCRIPTION_ID = "node_subscription_id" | |||
| PORT_MODE = "port_mode" | |||
| INTERNETPINNEN_PREFIX_SUBSCRIPTION_ID = "internetpinnen_prefix_subscription_id" | |||
| PEER_GROUP_SUBSCRIPTION_ID = "peer_group_subscription_id" | |||
There was a problem hiding this comment.
Do we need these constants in a Generic release?
| @@ -29,6 +29,7 @@ | |||
| IP_PREFIX_SUBSCRIPTION_ID, | |||
| NODE_SUBSCRIPTION_ID, | |||
| PARENT_IP_PREFIX_SUBSCRIPTION_ID, | |||
| PEER_GROUP_SUBSCRIPTION_ID, | |||
There was a problem hiding this comment.
We seem to leak some SURF specific constants. Maybe good to add least add a todo (in the code) to split/clean it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes cli commands to wrap alembic commands and add it to the core cli commands.