Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for python 3.9 #13

Merged
merged 1 commit into from
May 10, 2021
Merged

Update for python 3.9 #13

merged 1 commit into from
May 10, 2021

Conversation

hmvp
Copy link
Contributor

@hmvp hmvp commented May 4, 2021

Also added some more testing around domain models

@hmvp hmvp requested review from acidjunk and pboers1988 and removed request for acidjunk May 4, 2021 09:50
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021

Codecov Report

Merging #13 (90fc471) into main (706ef48) will increase coverage by 0.36%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   80.95%   81.31%   +0.36%     
==========================================
  Files          84       84              
  Lines        4531     4534       +3     
  Branches      559      559              
==========================================
+ Hits         3668     3687      +19     
+ Misses        711      701      -10     
+ Partials      152      146       -6     
Impacted Files Coverage Δ
orchestrator/domain/base.py 75.42% <61.53%> (+3.47%) ⬆️
orchestrator/types.py 97.61% <90.00%> (+0.02%) ⬆️
orchestrator/__init__.py 100.00% <100.00%> (ø)
orchestrator/utils/state.py 92.78% <100.00%> (+0.07%) ⬆️
orchestrator/utils/docs.py 82.43% <0.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706ef48...90fc471. Read the comment docs.

Also added some more testing around domain models
@hmvp hmvp force-pushed the update_for_3.9 branch from 79db9f5 to 90fc471 Compare May 4, 2021 10:35
Copy link
Collaborator

@acidjunk acidjunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new pydantic typing functions improve readability a lot. Great.

@pboers1988 pboers1988 merged commit 33e0271 into main May 10, 2021
@pboers1988 pboers1988 deleted the update_for_3.9 branch May 10, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants