-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow RO-Crate 1.0 suggestions #22
Conversation
Also CWL 1.2 has abstract CWL which we want
I set this as a SHOULD to not force the FormalParameters - not yet supported in WorkflowHub.
I don't think we should be picky about the filename, as anyone consuming a zip can simply look for ro-crate-metadata.json inside and thus determine it is an RO-Crate. I think it is true you want the ro-crate-metadata.json straight in the root, and do not like somefolder/ro-crate-metadata.json? .jsonld -> .json
moved signposting to the profile
moved signposting to the profile
…ut into workflow-ro-crate-1.0
Rendering of the updated Profile Crate |
assuming authors are Finn, Alan, Stian
"@type": [ | ||
"File", | ||
"SoftwareSourceCode", | ||
"HowTo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be ComputationalWorkflow
? Since this file is the actual workflow, not the abstract CWL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, this example should perhaps be amended to have both a ComputationalWorkflow
(which could be Nextflow) and a Abstract CWL HowTo
@stain should we have explicit types for the workflow languages (instead of |
Related to the above: since {
"@id": "test/test1/sort-and-change-case-test.yml",
"@type": [
"File",
"TestDefinition"
],
"conformsTo": {"@id": "https://w3id.org/ro/terms/test#PlanemoEngine"},
"engineVersion": ">=0.70"
},
{
"@id": "https://w3id.org/ro/terms/test#PlanemoEngine",
"@type": "SoftwareApplication",
"name": "Planemo",
"url": {"@id": "https://github.com/galaxyproject/planemo"}
} The use case I had in mind was multiple tests needing different engine versions, since this would not be valid: {
"@id": "https://w3id.org/ro/terms/test#PlanemoEngine",
"@type": "SoftwareApplication",
"name": "Planemo",
"url": {"@id": "https://github.com/galaxyproject/planemo"},
"version": 0.70
},
{
"@id": "https://w3id.org/ro/terms/test#PlanemoEngine",
"@type": "SoftwareApplication",
"name": "Planemo",
"url": {"@id": "https://github.com/galaxyproject/planemo"},
"version": 0.71
} I think the same would happen in the Workflow RO-Crate case. What if there's a secondary workflow that's written in the same language as the main workflow, but in a different version? You can't repeat the same workflow language entity with two different versions, can you? |
Agree, @simleo - rather than everyone defining their own new However I don't want to use So I will change the languages to be under the Not sure what are implication of this on https://github.com/seek4science/seek/blob/master/config/default_data/workflow_classes.yml and corresponding [ For now think they should still also be explicit in the crate, that means algorithm would still be able to match on |
On the problem with versions, I think you would need a second contextual entity. And then it is harder to make Now this profile itself does not say you need a Ideally some kind of I tried for instance to improve on the URL for Knime, since https://www.knime.com/ is a company and not a programming language - but they don't have a page about the .knwf format. |
I also fixed that the old examples had odd nesting with But I think that algorithm currently only tries to go into |
https://w3id.org/workflowhub/workflow-ro-crate/1.0 now live. RO-Crates previews:
In the Profile Crate I changed to use http://schema.org/Guide as discussed in hackathon. Not sure about PID entity which is needed to not violate |
0.2
and1.0-DRAFT
(to become1.0/
) with symlinks for current versions. Redirect instead?conformsTo
(thus forward compatible)programmingLanguage
to CWL 52a804flicense
can be overridden on individual files 766be08encodingFormat
andabout: ./
dfd8e20FormalParameter
?Content negotiation would be via https://w3id.org/workflowhub/workflow-ro-crate/1.0 (see https://github.com/perma-id/w3id.org/tree/master/workflowhub) which seems to work:
Now I think we may need to discuss several of these items before releasing this.
You can preview this in https://github.com/workflowhub-eu/about/blob/workflow-ro-crate-1.0/Workflow-RO-Crate/1.0-DRAFT/index.md