Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more customization #6

Closed
eikaramba opened this issue Jul 17, 2015 · 3 comments
Closed

more customization #6

eikaramba opened this issue Jul 17, 2015 · 3 comments

Comments

@eikaramba
Copy link

i wanted to use this library, however there are a lot of things missing for a regular use case. I give you a short list, if that is okay :)

  • If i enter more than a few words the tooltip expands beyond the screen borders. It shold automatically break the lines if necessary. A simple check if the screen boundaries are reached would be good.
  • The overlay is not alway exactly where i want it, e.g. i have an icon and the overlay is a little bit misplaced around it. so it would be good to be able to "adjust" its position and size through some relative value like "+=3dp" (add 3dp to the size, or move it 3dp to the left)...
  • Chaining of tourguides. Is this planned, how do i do it currently? e.g. i want the user first to click here, then there, and then here.
  • Option to just show the tourGuide without user interaction --> Let it close itself after the user clicked SOMEHWHERE on the Screen.

BTW: Great work nevertheless, really looking forward to this library as the de facto standard for "overlay-helping-tour-guides"

@worker8
Copy link
Owner

worker8 commented Jul 26, 2015

Thanks for your feedback.

If i enter more than a few words the tooltip expands beyond the screen borders. It shold automatically break the lines if necessary. A simple check if the screen boundaries are reached would be good.

This is a bug, I need to fix it.

The overlay is not alway exactly where i want it, e.g. i have an icon and the overlay is a little bit misplaced around it. so it would be good to be able to "adjust" its position and size through some relative value like "+=3dp" (add 3dp to the size, or move it 3dp to the left)...

I can understand the the size being a parameter that you can set, I will add it to the to do list. But in what cases do you need to adjust the position? I thought it's best at the center like what it is now?

Chaining of tourguides. Is this planned, how do i do it currently? e.g. i want the user first to click here, then there, and then here.

This can be done now, I added an example in the Demo app in InSequenceActivity.java, check it out!

Option to just show the tourGuide without user interaction --> Let it close itself after the user clicked SOMEHWHERE on the Screen.

This is already in the Roadmap wiki

@eikaramba
Copy link
Author

The position adjusting is just because sometimes you don't want it to be centered, or the automatically extracted center values are not the same as the "visually perceived" center. e.g. if a button image is 200px width but the actual icon is only on the left or so. (bad example but i guess you know what i mean)

thx for the reply and the infos

worker8 added a commit that referenced this issue Aug 7, 2015
@worker8
Copy link
Owner

worker8 commented Aug 7, 2015

I think I can what you mean, I believe the use case is there, but it will not be a very common one. I will put it in the todo list (good to have).

I added some boundary checking when text in ToolTip gets too long. It will wrap itself now. This is how it looks like:
output

I will close this issue since the bug is fixed, and the rest of the suggestions have either been implemented or added to the roadmap wiki.

@worker8 worker8 closed this as completed Aug 7, 2015
svvorf added a commit to svvorf/TourGuide that referenced this issue May 22, 2016
…rker8#6). Offset values (left and top, both can be either positive or negative integers, in pixels) are stored in a two-value array in a field of the Overlay class. Overlay.setHoleOffsets() is provided for setting those values to an overlay instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants