Fix 'Welcome' formatting #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
reviewed
Dec 14, 2023
There was a problem hiding this comment.
No formatting PRs please. It's gonna go back and forth.
Let's automated this instead like it is for JS, Rust and Python.
I have a draft PR here with Vala formatting support https://github.com/workbenchdev/Workbench/pull/527/files
@lw64 could you take over?
There are the important bits:
https://github.com/workbenchdev/Workbench/pull/527/files#r1304352148
|
The PR also removes unneeded Gtk.Init() and changes the casting to the preferred one - it probably cannot be done by a formatter, unless it is very smart. |
|
@UrtsiSantsi could you revert the formatting changes? I have a draft PR to solve and automate formatting issues |
|
I removed all the formatting changes. |
lw64
approved these changes
Dec 18, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the comments in #34 I made the same changes here. Other Vala demos also have formatting problems, but this is the most visible.