Add GOM demo #200
Merged
Add GOM demo #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Initial implementation, has bugs
Add text based filtering to showcase vs ID filtering Design is still a WIP
andyholmes
requested changes
Aug 10, 2024
There was a problem hiding this comment.
This looks really great.
I think all this needs is some minor UX improvements, and few spots where the code could clearer (since demos are for educational purposes).
It's okay to put a few code comments highlighting key elements as well, such as the primary key for a table and the auto-migrate functionality.
Use SearchEntry for text search and SpinButton for ID search and subsequent logic changes Cleaned up logic when no results found Re-organized the UI, cleaner implementation
andyholmes
requested changes
Aug 13, 2024
BharatAtbrat
added a commit
to workbenchdev/Workbench
that referenced
this pull request
Aug 13, 2024
Add Gom as dependency for Gom demo ref #workbenchdev/demos#200
andyholmes
pushed a commit
to workbenchdev/Workbench
that referenced
this pull request
Sep 5, 2024
|
Can you rebase this when you get a moment, so we can be sure the GOM dependency is working? |
BharatAtbrat
force-pushed
the
atbrat/gom_demo
branch
from
44f0c19
to
ff6af5b
Compare
sonnyp
requested changes
Oct 2, 2024
rename folder to Database change description, title replace var with let add newline
remove Toasts and subsequent use temporarily disable closeDatabase function for checker use sqlite databse
can't leave the adapter open
|
I pushed some tweaks 69f6079
|
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if there are improvements!
Screengrabs of the current state [after commit ]:
2024-08-12.18-27-16.mp4