Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: add Libmanette entry #309

Closed
wants to merge 17 commits into from
Closed

Conversation

halfmexican
Copy link
Contributor

@halfmexican halfmexican changed the title Halfmexican/libmanette library: add Libmanette entry Jun 8, 2023
@halfmexican halfmexican self-assigned this Jun 8, 2023
@halfmexican halfmexican marked this pull request as ready for review June 8, 2023 19:36
@halfmexican halfmexican requested a review from sonnyp June 8, 2023 19:37
{
"name": "libmanette",
"buildsystem": "meson",
"config-opts": ["-Dgudev=disabled"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the config-opts what fixed it in flatpak?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonnyp
Copy link
Contributor

sonnyp commented Jun 18, 2023

I have sent a MR to fix org.gnome.Sdk https://gitlab.gnome.org/GNOME/gnome-build-meta/-/merge_requests/2217

Let's see.

@sonnyp
Copy link
Contributor

sonnyp commented Feb 10, 2024

The Workbench/SDK side of things will be fixed with 46 via https://gitlab.gnome.org/GNOME/gnome-build-meta/-/merge_requests/2662

@halfmexican could you reopen this against (even if it doesn't work yet) https://github.com/workbenchdev/demos so we can consider it for Workbench 46? Just the demo, not the manifest stuff.

See also https://floss.social/@sonny/111907486030723359

@sonnyp sonnyp added this to the 46 milestone Feb 10, 2024
@halfmexican
Copy link
Contributor Author

Yep, will do

@sonnyp
Copy link
Contributor

sonnyp commented Feb 12, 2024

workbenchdev/demos#88

@sonnyp sonnyp closed this Feb 12, 2024
@sonnyp sonnyp deleted the halfmexican/libmanette branch February 12, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libmanette example
2 participants