Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Remove manual string verification step #83

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Dec 10, 2021

#46 added a step to manually verify string localizations due to issue wordpress-mobile/gutenberg-mobile#3466.

Now that the issue has been resolved, this PR proposes removing the manual check.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@guarani guarani merged commit 7b73287 into develop Dec 10, 2021
@guarani guarani deleted the update/remove-string-verification-step branch December 10, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants